Skip to content

Update and fixup the SPI #10476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

Update and fixup the SPI #10476

merged 4 commits into from
Jul 10, 2025

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Jul 8, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

  1. Make a priv data read API for probed SPI device
  2. Fixup the SPI device pre-alloc
  3. Fixup the QSPI transfer result check
  4. Update the SPI Kconfig for DM

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

GuEe-GUI added 2 commits July 8, 2025 18:22
@GuEe-GUI
Make a priv data read API for probed SPI device
e165fcc 
Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
Fixup the SPI device pre-alloc
7735d13 
May the bus is a QSPI, we should check the mode before alloc the SPI
device.

The raw API the SPI mode default but the SPI DM bus probe run before
the SPI mode confirm, we should move the SPI register API alone, then
confirm the bus mode before register.

Signed-off-by: GuEe-GUI <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: components

Path: components
Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/drivers/include/drivers/dev_spi.h
  • components/drivers/spi/Kconfig
  • components/drivers/spi/dev_qspi_core.c
  • components/drivers/spi/dev_spi_bus.c
  • components/drivers/spi/dev_spi_core.c

🏷️ Tag: driver_spi

Path: components/drivers/spi
Reviewers: wdfk-prog

Changed Files (Click to expand)
  • components/drivers/spi/Kconfig
  • components/drivers/spi/dev_qspi_core.c
  • components/drivers/spi/dev_spi_bus.c
  • components/drivers/spi/dev_spi_core.c

📊 Current Review Status (Last Updated: 2025-07-10 04:17 UTC)

  • ⌛ @Maihuanyi Pending Review
  • ⌛ wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@GuEe-GUI
Copy link
Contributor Author

GuEe-GUI commented Jul 9, 2025

@chasel @wdfk-prog @Rbb666

wdfk-prog
wdfk-prog reviewed Jul 9, 2025
View reviewed changes
@GuEe-GUI GuEe-GUI requested a review from wdfk-prog July 10, 2025 01:19
wdfk-prog
wdfk-prog suggested changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@wdfk-prog wdfk-prog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • result 得定义成 rt_ssize_t 类型,其他ok

GuEe-GUI added 2 commits July 10, 2025 12:16
@GuEe-GUI
Fixup the QSPI transfer result check
b14468a 
The result could < 0 (with error number) now.

Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
Update the SPI Kconfig for DM
39d390d 
Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
Copy link
Contributor Author

@wdfk-prog @Rbb666 对 components/drivers/spi/dev_qspi_core.c 和 components/drivers/include/drivers/dev_spi.h 进行了更新，请继续检查

wdfk-prog
wdfk-prog approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@wdfk-prog wdfk-prog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rbb666
Copy link
Member

Rbb666 commented Jul 10, 2025

LGTM

@Rbb666 Rbb666 merged commit 8a7ef41 into RT-Thread:master Jul 10, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

@wdfk-prog wdfk-prog wdfk-prog approved these changes

Assignees
No one assigned
Labels
component: drivers/spi component: drivers Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuEe-GUI @Rbb666 @wdfk-prog