Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce self host runner #3237

Merged
merged 38 commits into from
Mar 23, 2025
Merged

ci: introduce self host runner #3237

merged 38 commits into from
Mar 23, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Mar 22, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 8:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2025 8:55am

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix: restrict workflow triggers to dev branch only

Change Summary:
Modified GitHub Actions workflow to limit triggers to 'dev' branch and changed build environment from macOS to self-hosted.

Code Review:

Code Review

File: .github/workflows/build-eas-development.yml

  1. Line 6 and Line 13 (branches: [dev]):

    • The removal of the main branch from both the push and pull_request triggers limits the workflow to only run on changes to the dev branch. If this change was unintended or the workflow should still be triggered for the main branch, this needs to be corrected. Otherwise, ensure this aligns with the intended CI/CD process.
  2. Line 21 (runs-on: self-hosted):

    • Changing the runner from macos-latest to self-hosted requires verification:
      • Ensure a self-hosted runner is properly configured and has the necessary permissions to execute this workflow.
      • Confirm that the self-hosted runner has all required dependencies to build an iOS IPA (e.g., Xcode, required libraries).
      • If this was unintentional, revert to macos-latest.

Unless explicitly confirmed, changes to runners can disrupt the build process, especially for iOS builds that typically require a macOS environment.


If these points have been carefully verified and are intentional, no further changes are needed. Otherwise, adjustments may be required to ensure workflow functionality.

Suggested Actions:

  • Verify branch trigger changes (main removal).
  • Confirm self-hosted runner configuration for iOS builds.

This reverts commit 05d19cf.
This reverts commit 70e0c35.
@hyoban hyoban changed the title ci: test self host runner ci: introduce self host runner Mar 23, 2025
@hyoban hyoban marked this pull request as ready for review March 23, 2025 08:39
@@ -8,9 +8,9 @@
"bump": "vv",
"db:generate": "drizzle-kit generate",
"dev": "npm run start",
"eas-build-post-install": "rm -rf $TMPDIR/metro-cache",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important to avoid expo/eas-cli#2959

@hyoban hyoban merged commit 2f8f137 into dev Mar 23, 2025
15 checks passed
@hyoban hyoban deleted the ci/03-22-test-self-host branch March 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant