Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
activitysim/estimation
module, primarily focusing on updating thelarch
version handling, modifying test cases, and adjusting model parameters.The key change is applying a constraint on the trip model choice model, to solve an over specification problem and ensure the estimation results are stable.
The most important changes are grouped by their themes below.
Test Case Adjustments:
test_location_model
function to lock a parameter and set a cap for the "trip_destination" model to ensure model identifiability.test_simple_simulate
function inactivitysim/estimation/test/test_larch_estimation.py
to also use the "SLSQP" method for the "trip_destination" model. The SLSQP algorithm obeys constraints on parameter values, while the BHHH algorithm does not, yielding very different answers. Which is "better" depends on the modeler's opinion on the validity of the constraints.Version Handling:
larch
version check inactivitysim/estimation/larch/__init__.py
to handle development versions correctly.Model Parameter Updates:
test_loc_trip_destination_BHHH_loglike.csv
andtest_loc_trip_destination_SLSQP_loglike.csv
to reflect new model results. [1] [2]test_loc_trip_destination_SLSQP_size_spec.csv
.CSV File Updates:
test_location_model_trip_destination_BHHH_None_.csv
to reflect new model results.test_location_model_trip_destination_SLSQP_None_.csv
with updated parameter values for the "trip_destination" model.