Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into estimation_enhancem…
Browse files Browse the repository at this point in the history
…ents
  • Loading branch information
dhensle committed Dec 14, 2024
2 parents aa874f6 + 171f172 commit a5e137b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion activitysim/abm/models/util/logsums.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,10 @@ def compute_location_choice_logsums(
)

nest_spec = config.get_logit_model_settings(logsum_settings)
nest_spec = simulate.eval_nest_coefficients(nest_spec, coefficients, trace_label)
if nest_spec is not None: # nest_spec is None for MNL
nest_spec = simulate.eval_nest_coefficients(
nest_spec, coefficients, trace_label
)

locals_dict = {}
# model_constants can appear in expressions
Expand Down
2 changes: 1 addition & 1 deletion docs/users-guide/example_performance.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ See more complete results and discussion
| write tables | 8.1 | 7.9 | 7.8 | 7.7 | 7.3 | 7.5 |
| Total Runtime | 309.5 | 211.4 | 186.2 | 182.4 | 177.3 | 180 |

### Single Process, Sharrow Disabled
### Multiprocessing, Sharrow Disabled

The following performance metrics were collected for the SANDAG example model,
running on a Windows server with 24 cores and 500GB of RAM (same as the results above),
Expand Down
4 changes: 2 additions & 2 deletions docs/users-guide/modelsetup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ This method is recommended for ActivitySim users who also wish to customize the
2. Create a conda environment (basically a Python install just for this project)
using mambaforge prompt or conda prompt depending on the package manager you use (on Windows) or the terminal (macOS or Linux)::

mamba create -n asim python=3.9 activitysim -c conda-forge --override-channels
mamba create -n asim python=3.10 activitysim -c conda-forge --override-channels

This command will create the environment and install all the dependencies
required for running ActivitySim. It is only necessary to create the environment
once per machine, you do not need to (re)create the environment for each session.
If you would also like to install other tools or optional dependencies, it is
possible to do so by adding additional libraries to this command. For example::

mamba create -n asim python=3.9 activitysim jupyterlab larch -c conda-forge --override-channels
mamba create -n asim python=3.10 activitysim jupyterlab larch -c conda-forge --override-channels

This example installs a specific version of Python, version 3.9. A similar
approach can be used to install specific versions of other libraries as well,
Expand Down

0 comments on commit a5e137b

Please sign in to comment.