Add type hints #19
Open
Add type hints #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drj11
reviewed
Oct 21, 2020
| @@ -26,7 +26,7 @@ like Sphinx encourages. | |||
|
|
|||
| ## [Typehints](https://docs.python.org/3/library/typing.html) | |||
|
|
|||
| * Do not use typehints. | |||
| * Please use typehints. | |||
|
Did you run |
willfurnass
force-pushed
the
type-hints
branch
from
d7efe95
to
b421312
Compare
|
Not compatible with the latest |
willfurnass
force-pushed
the
type-hints
branch
from
b421312
to
d483a13
Compare
|
Rebased the PR on |
|
In a way it's quite funny:
|
|
The use of the return code to indicate the number of type annotations is inspired! I think this might be check mate so feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for fun. Won't be offended if this isn't merged.
NB type hints allowed for the identification of interesting potential issues e.g.
Element.textcan returnNone.