Added support Emerald Rapids

[vxirau]

Hello!

I followed the instructions in https://github.com/RRZE-HPC/likwid/wiki/AddX86Support to add Emerald Rapids support.

Events are the same as for Sapphire according to perfmon intel events.

Let me know if there is something else that should be reviewed.

[TomTheBear]

Hi, looks very good. Thanks for adding it.

One important change is missing though. You should add it to src/power.c (around here). Otherwise the ENERGY group will not work.

Some minor additions:

• For sysFeatures, add the arch to the list here
• For sysFeatures rapl component, EmeraldRapids probably uses the same energy units (for conversion) as SapphireRapids, so you can add EmeraldRapids here and here
• For support for the fixed TOPDOWN_SLOTS event, you should add it to the condition

Any comments on AddX86Support? Something unclear? I'm happy to update the page.

[vxirau]

Hi @TomTheBear !

Thank you for your response. I just made the changes you mentioned.

The AddX86Support guide was very clear and helpful! The only thing I didn't get from the guide was the sysFeatures being something mandatory to change! But of course it was easy to add.

I've also updated the README to reflect the change. Should I update the changelog too? As mentioned in the wiki?

What about the wiki itself? Something like https://github.com/RRZE-HPC/likwid/wiki/SapphireRapids ?

Thanks!

[TomTheBear]

SysFeatures is a quite recent development. It is still experimental and has to be explicitly enabled at build time. I added it to the page but I have to first write better documentation for extending SysFeatures. At the moment, it describes the changes not well.

Please add it to the changelog, I forgot to mention that.

There is also the architecture docs in doc/archs and the architecture page in the wiki. You can do that or leave it to me. It's just copying the pages and changing some identifiers.

[vxirau]

Not sure how you want the wiki done! I believe the rest is OK :)

[TomTheBear]

It's close to perfection 🥇 . Thanks :)

I'll add the wiki page

[TomTheBear]

https://github.com/RRZE-HPC/likwid/wiki/EmeraldRapids