DrawingPointerTool (due in 1.19) can now drag/move drawings #5846
+228
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
b.t.w. this is ready for a review. |
src/main/java/net/rptools/maptool/client/tool/drawing/DrawingPointerTool.java
Show resolved
Hide resolved
| * <li><kbd>Left Press</kbd> Prepare to drag. Show the template(s) size/radius | ||
| * <li><kbd>Left Drag</kbd> if a GM or server movement policy permits, move the drawable(s), | ||
| * templates will show the movement distance according using the movement metric setting. | ||
| * <li><kbd>Left Drag</kbd>+<kbd>CTRL</kbd> if a drawing, snap dragging to grid. |
Collaborator
There was a problem hiding this comment.
Small usability complaint: if start dragging a drawing without holding CTRL (no snapping), then press CTRL while still dragging (to enable snapping), I would expect the drawing to start snapping according to its original position, i.e., it should be offset by some whole number of grid cells from where the original drawing is. Instead what happens is that it snaps according to the position the dragged drawing is at when I start holding CTRL.
Contributor
Author
There was a problem hiding this comment.
Good catch, I will take a look.
Contributor
Author
There was a problem hiding this comment.
This should be resolved now and ready for a re-review.
kwvanderlinde
approved these changes
Nov 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kwvanderlinde
requested changes
Nov 13, 2025
src/main/java/net/rptools/maptool/client/tool/drawing/DrawingPointerTool.java
Outdated
Show resolved
Hide resolved
kwvanderlinde
approved these changes
Nov 13, 2025
github-project-automation
bot
moved this from In-Progress
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progresses #2743
Description of the Change
DrawingPointerTool(due in 1.19) can now drag/move drawings that have been drawn by MapTool's drawings tools.DrawPanelPopupMenucan now duplicate selected drawings.Possible Drawbacks
None anticipated
Documentation Notes
With the DrawingPointerTool active, selected drawings or groups of drawings can now be dragged by the mouse.
Selected drawings can now be duplicated using the drawing popup menu, and using
CTRL+Vwhen the DrawingPointerTool is active.Release Notes
Drawn drawings can now be dragged.
This change is