Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix deserialization order to match serialization #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nmcglo
Copy link
Member

@nmcglo nmcglo commented Nov 17, 2017

The previous commit, 86240a3, addressed the hardcoding of all LP
deserialization being mapped to the first LP type. This fix was a
positive step but left a previously unaddressed issue:

The deserialization was not done in the same order as serialization.
The result of this was that in simulations with more than one KP, LPs
may end up with GIDs and RNGs different than what they had been given
at the start of the original simulation.

This bug could have gone unnoticed in simulations with only one LP type
as there would not be any runtime errors generated unless change in GID
or RNG detection was done at the model level.

This commit addresses the issue and makes the deserialization match the
serialiation process.

The previous commit, 86240a3, addressed the hardcoding of all LP
deserialization being mapped to the first LP type. This fix was a
positive step but still left a previously unaddressed issue:

The deserialization was not done in the same order as serialization.
The result of this was that in simulations with more than one KP, LPs
may end up with GIDs and RNGs different than what they had been given
at the start of the original simulation.

This bug could have gone unnoticed in simulations with only one LP type
as there would not be any runtime errors generated unless change in GID
or RNG detection was done at the model level.

This commit addresses the issue and makes the deserialization match the
serialiation process.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant