[Misc] Upload a shell for bare-metal #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexei-V-Ivanov-AMD
previously approved these changes
Nov 11, 2024
install-vlllm-for-bare-metal.sh
Outdated
Comment on lines
100
to
102
| # cd /opt/rocm/share/amd_smi \ | ||
| # && pip wheel . --wheel-dir=dist \ | ||
| # && pip install dist/*.whl \ |
There was a problem hiding this comment.
This block of code lacks initial comment.
I guess it is pretty self-explanatory, but to be persistent in style, let's add a small comment there as well.
Concurrensee
force-pushed
the
for-bare-metal
branch
from
85811e5
to
1bc82a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload a shell script to install rocm/vllm for bare-metal