Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Test Suite - Replace fstrings and subprocess calls to support old/new versions of Python #399

Merged
merged 10 commits into from
Jul 24, 2024
Merged

RPP Test Suite - Replace fstrings and subprocess calls to support old/new versions of Python #399

merged 10 commits into from
Jul 24, 2024

Conversation

r-abishek
Copy link
Member

This PR adds relevant changes to support RPP test suite on old/new versions of python - tested on python 2.7, 3.5, 3.10

  • Replaces usage of fstrings with just strings for python backward compatibility
  • Replaces usage of subprocess.run with just subprocess.call / subprocess.Popen for python backward compatibility
  • Minor bugfix in test suite help display

@r-abishek
Copy link
Member Author

@LakshmiKumar23 @kiritigowda This PR now passes CI and should support older and newer versions of Python.

@LakshmiKumar23
Copy link
Contributor

@LakshmiKumar23 @kiritigowda This PR now passes CI and should support older and newer versions of Python.

I will update the ticket so QA can test and confirm

rrawther
rrawther approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LakshmiKumar23 to run tests to see if the issue is fixed

@kiritigowda kiritigowda merged commit 2a13f48 into ROCm:develop Jul 24, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-abishek @LakshmiKumar23 @rrawther @kiritigowda @HazarathKumarM