-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPP Audio Support HIP - Non silent region #395
Merged
kiritigowda
merged 97 commits into
ROCm:develop
from
r-abishek:ar/audio_support_1_non_silent_region_hip
Jul 24, 2024
Merged
Changes from all commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
c33af22
Bump rocm-docs-core[api_reference] from 0.35.0 to 0.35.1 in /docs/sph…
dependabot[bot] 7adaa5f
added initial skeleton code for the NSR HIP kernel
sampath1117 8e13762
added test suite support for audio in HIP
sampath1117 1348130
initial commit for working NSR kernel with batch size 1
sampath1117 3c0c3eb
added max reduction kernel for finding max value in MMS buffer
sampath1117 14f6334
Bump rocm-docs-core[api_reference] from 0.35.1 to 0.36.0 in /docs/sph…
dependabot[bot] 95c3272
Merge branch 'master' into develop
kiritigowda edf0e99
optimized find region kernel
sampath1117 f3d105f
added profiler support for hip test suite
sampath1117 701b9fc
modified kernel launch configuration for moving_mean_square_hip_tenso…
sampath1117 3102d38
changed the pinned memory for mmsArr to HIP memoryy
sampath1117 e5d469c
modified the datatype for NSR HIP kernel outputs from float to int
sampath1117 980dade
modify NSR HOST kernel outputs to int
sampath1117 0c4c787
change shm_pos to smem_pos
sampath1117 99ccead
minor change
sampath1117 641f653
Docs - Bump rocm-docs-core[api_reference] from 0.36.0 to 0.37.0 in /d…
dependabot[bot] 5568573
Link cleanup (#326)
LisaDelaney a6749ba
Update notes
LisaDelaney a255906
Docs - Bump rocm-docs-core[api_reference] from 0.37.0 to 0.37.1 in /d…
dependabot[bot] d3df761
RPP Voxel Flip on HIP and HOST (#285)
r-abishek ebecb42
RPP Vignette Tensor on HOST and HIP (#311)
r-abishek fc1410b
Bump rocm-docs-core[api_reference] from 0.37.1 to 0.38.0 in /docs/sph…
dependabot[bot] cf91791
Merge branch 'develop' into sr/nsr_hip
sampath1117 64ee621
minor code cleanup
sampath1117 bc66023
changed the declaration of shared memory
sampath1117 3ebd7c3
RPP Tensor Audio Support - Resample (#310)
r-abishek 76f31df
Docs - Missing input and output images for Doxygen (#331)
r-abishek b83f910
Scratch buffers rename for HOST and HIP (#324)
r-abishek ebeb131
Update CMakeLists.txt
kiritigowda 2e40516
removed f16 includes since not needed for audio
sampath1117 fbd85c6
Merge remote-tracking branch 'develop' into sr/nsr_hip
sampath1117 46299d5
modified scratch buffer name used in NSR hip kernel
sampath1117 29efdb7
moved gridStride as param from kernel launch
sampath1117 3f5319b
restructured python test suite
sampath1117 44c29b1
minor change
sampath1117 6bdc00e
removed gridStride based processing in moving_mean_square_hip_tensor …
sampath1117 39fb985
build fix
sampath1117 bd28ffd
add comment for smem_pos function
sampath1117 cf85008
fixed spacing in Doxygen
sampath1117 1147bfe
Update CMakeLists.txt
kiritigowda 201c5d6
Merge remote-tracking branch 'develop' into sr/nsr_hip
sampath1117 5e3fc7a
Bump rocm-docs-core[api_reference] from 0.38.1 to 1.0.0 in /docs/sphi…
dependabot[bot] b6b7cc5
Bump rocm-docs-core[api_reference] from 1.0.0 to 1.1.0 in /docs/sphin…
dependabot[bot] e16ad7a
RPP Gaussian Noise Voxel Tensor on HOST and HIP (#323)
r-abishek b5568c4
Merge branch 'develop' into sr/nsr_hip
sampath1117 6f16fc3
modify CHECK to CHECK_RETURN_STATUS in hip audio test suite
sampath1117 1d7377d
Merge branch 'develop' into sr/nsr_hip
sampath1117 c44a014
removed additional line added in merge
sampath1117 77e14ef
Minor common-fixes for HIP (#345)
r-abishek 34f3f6d
Readme Updates: --usecase=rocm (#349)
kiritigowda ab52683
RPP Tensor Audio Support - Spectrogram (#312)
r-abishek ee0d6fe
Update CHANGELOG.md (#352)
r-abishek 2decd32
RPP Tensor Audio Support - Slice (#325)
r-abishek 30ce1d6
RPP Tensor Audio Support - MelFilterBank (#332)
r-abishek 64ae74f
RPP Tensor Normalize ND on HOST and HIP (#335)
r-abishek 1a3015c
SWDEV-459739 - Remove the package obsolete setting (#353)
raramakr 7d233bc
Merge branch 'develop' into sr/nsr_hip
sampath1117 550e981
modified code to use globalThreads_z from description pointer instead…
sampath1117 4cb8d4b
Audio support merge commit fixes (#354)
r-abishek 9bd6566
Merge branch 'develop' into sr/nsr_hip
sampath1117 69e985c
renamed instances of tensor_hip_audio to tensor_audio_hip
sampath1117 5498e3a
made helper functions inline
sampath1117 bde44ba
added comments for prev_pow2 and next_pow2 functions
sampath1117 067a425
change max reduction kernel block size from 512 to 256
sampath1117 995bde5
change base types to RPP types in hip executor
sampath1117 07126db
added error codes for tile length and shared memory
sampath1117 13efda2
minor change
sampath1117 d4219f8
Bump rocm-docs-core[api_reference] from 1.1.1 to 1.1.2 in /docs/sphin…
dependabot[bot] 264392b
Docker updates (#356)
LakshmiKumar23 9907a49
Version Updates (#359)
LakshmiKumar23 d705d1b
remove square helper function in HIP kernel
sampath1117 04e1c75
optimize index computation in prefix_sim function
sampath1117 2256d19
add more comments in code for better readability
sampath1117 faa34e6
Merge branch 'develop' into sr/nsr_hip
sampath1117 98c8412
Merge branch 'develop' into sr/nsr_hip
sampath1117 8aa674c
Merge branch 'develop' into sr/nsr_hip
sampath1117 63a655d
removed print statement for invalid cases in hip executor
sampath1117 8acb1ad
vectorized computations in compute_prefix_sum function
sampath1117 fed7828
increased scratch memory allocation and removed the hipMalloc and hip…
sampath1117 a47f70d
Merge branch 'develop' of https://github.com/r-abishek/rpp into sr/ns…
r-abishek d7333e8
added explanation for the scratch memory allocated in HIP backend
sampath1117 cf6eb41
added comments for compute_prefix_sum helper function
sampath1117 ca66f60
Merge branch 'develop' into sr/nsr_hip
sampath1117 3ed52ea
Merge branch 'develop' into sr/nsr_hip
sampath1117 9bcee81
added audio flag changes in HIP test suite cmake
sampath1117 0684b56
removed empty blank line
sampath1117 76fd42e
Merge pull request #250 from sampath1117/sr/nsr_hip
r-abishek 7c7324a
added const variable for maximum MMS buffer size
sampath1117 8924c31
added few more comments for moving mean sqaure hip kernel
sampath1117 0789ed3
Merge pull request #289 from sampath1117/sr/nsr_hip_pr_changes
r-abishek 5ef9dc5
minor change to comment
sampath1117 ea1b3eb
Merge pull request #292 from sampath1117/sr/nsr_hip_pr_changes
r-abishek 61b45e8
Merge branch 'develop' into ar/audio_support_1_non_silent_region_hip
r-abishek 5d4bafa
audio test suite changes for python 2 compatibility
sampath1117 60b6966
Merge pull request #293 from sampath1117/sr/nsr_hip_pr_changes
r-abishek 761a49b
Merge branch 'develop' into ar/audio_support_1_non_silent_region_hip
r-abishek cd8ae4d
Merge branch 'develop' into ar/audio_support_1_non_silent_region_hip
kiritigowda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
MIT License | ||
|
||
Copyright (c) 2019 - 2024 Advanced Micro Devices, Inc. | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. | ||
*/ | ||
|
||
#ifndef HIP_TENSOR_AUDIO_AUGMENTATIONS_HPP | ||
#define HIP_TENSOR_AUDIO_AUGMENTATIONS_HPP | ||
|
||
#include "kernel/non_silent_region_detection.hpp" | ||
|
||
#endif // HIP_TENSOR_AUDIO_AUGMENTATIONS_HPP |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is only including one header file, you don't really need a separate header file. You can directly include kernel/non_silent_region_detection.hpp in where it is referrenced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rajy,
This header file is used for including all audio HIP kernels
Currently since this is the first audio HIP PR, this has only included only 1 HIP kernel
Once few more audio HIP kernels are merged, this header will have more included like it is for HOST
https://github.com/ROCm/rpp/blob/develop/src/modules/cpu/host_tensor_audio_augmentations.hpp