Infinite recursion fix #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and then hsa_api_ can be reset with provided table
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that rocm-4.5.2 tag is one commit ahead of rocm-4.5.x branch and that commit contains only newly added comments. Therefore, I decide to post the PR based on the rocm-4.5.x.
The main change is that
hsa_api_becomes a member rather than a static member ofHsaRsrcFactory. This ensures thathsa_api_will always be initialized with the public HSA function entries (so that one can useHsaRsrcFactoryobject to call HSA functions) and then one can resethsa_api_with internal HSA implementations for intercepting HSA calls.This fixes #66 for both collecting performance counters and getting code object URI from roctracer.