-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface proposal : pull request 3 #55
base: rocm-4.3.x
Are you sure you want to change the base?
Commits on Sep 21, 2021
-
allow fine-grained control on several APIs
Deleted a line that makes rocprof abort when using fine grained control one several APIs at a time. The parsing function in libtracer_tool.so that parses the input XML file that specifies the functions for which the user wants to activate the tracing callbacks seems to handle correctly cases where fine-grained control is used on several APIs. This line can be safely deleted.
Configuration menu - View commit details
-
Copy full SHA for 125e1b1 - Browse repository at this point
Copy the full SHA 125e1b1View commit details
Commits on Sep 22, 2021
-
Isolate flushing instructions for metrics
Isolated flushing instructions into a wrapping function. The file descriptor used for flushing is the one that is globally defined and not the one stored in the context_entry_t object as it is always the one that is defined globally that is used. If using a globally defined file descriptor is problematic (however it is the norm in the libtracer_tool.so library in ROCTracer) rather than passing it through arguments, the wrapping flushing function can be modified to take a void pointer. The file descriptor can then be passed through this pointer and be used in the default flushing function.
Configuration menu - View commit details
-
Copy full SHA for 2b0aab5 - Browse repository at this point
Copy the full SHA 2b0aab5View commit details -
Isolate flushing instructions for kernel events
Isolated flushing instructions into a wrapping function. The file descriptor used for flushing is the one that is globally defined and not the one stored in the context_entry_t object as it is always the one that is defined globally that is used. If using a globally defined file descriptor is problematic (however it is the norm in the libtracer_tool.so library in ROCTracer) rather than passing it through arguments, the wrapping flushing function can be modified to take a void pointer. The file descriptor can then be passed through this pointer and be used in the default flushing function.
Configuration menu - View commit details
-
Copy full SHA for 5ccee80 - Browse repository at this point
Copy the full SHA 5ccee80View commit details
Commits on Sep 23, 2021
-
Update metrics flushing function signature
The signature of the function that flush metrics has been updated in order to have a standard signature for all the flushing functions. A new data structure that is passed as the only one argument for the function has also been defined
Configuration menu - View commit details
-
Copy full SHA for 65161e2 - Browse repository at this point
Copy the full SHA 65161e2View commit details -
Update kernel flushing function signature
As for the metrics, the kernel flushing function signature has been updated and a new data structure has been defined
Configuration menu - View commit details
-
Copy full SHA for 24bf30f - Browse repository at this point
Copy the full SHA 24bf30fView commit details