SWDEV-555888 - Fix a typo #1941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo issue that will fail querring on 64+ logical processors in Windows.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical typo in the Windows NUMA node enumeration code that was causing failures on systems with 64 or more logical processors. The issue was using the incorrect constant RelationNumaNode instead of RelationNumaNodeEx when calling GetLogicalProcessorInformationEx.
- Corrected Windows API constant from
RelationNumaNodetoRelationNumaNodeExin two locations - Fixes query failures on Windows systems with 64+ logical processors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo issue that will fail querring on 64+
logical processors in Windows.
Motivation
see above
Technical Details
.
Test Plan
test specific test
Test Result
pass
Submission Checklist