Update version number and changelog for ROCm 6.1 (#169) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjwu
requested review from
pfultz2,
lawruble13,
cgmb and
a team
as code owners
CMakeLists.txt
Outdated
| @@ -20,7 +20,7 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/share/rocmcmakebuildtool | |||
| include(ROCMCreatePackage) | |||
| include(ROCMSetupVersion) | |||
|
|
|||
| rocm_setup_version(VERSION 0.11.0) | |||
| rocm_setup_version(VERSION 0.12.0) | |||
There was a problem hiding this comment.
Should this be 0.13.0? That's what the changelog says.
The version is 0.12.0 in the 6.1 release branch https://github.com/ROCm/rocm-cmake/blob/release-staging/rocm-rel-6.1/CMakeLists.txt
There was a problem hiding this comment.
created #210 to address this. will cherry pick that change into this PR if it is merged
cgmb
approved these changes
Jul 14, 2024
|
Root cause was that I couldn't merge #171 until after branching due to test failures... or, at least, one of the root causes. |
* Update version in CMakeLists.txt to match changelog * Fix markdownlint formatting in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.