Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners for documentation #168

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Jan 24, 2024

Relates to ROCm/ROCm#2832
Adding documentation team as codeowners for documentation.
Goal is to make this group of code owners reviewers when merging documentation changes.

Please note that this requires the team to be added as a role with Write permissions.

Copy link
Collaborator

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the executable permissions from the codeowners file.

@samjwu
Copy link
Member Author

samjwu commented Feb 1, 2024

Please remove the executable permissions from the codeowners file.

Fixed in latest.

Also, would someone with admin permissions to this repo be able to add the ROCm Documentation team with write permissions? GitHub flags the additions to the CODEOWNER file as an error otherwise. Thanks!

@samjwu samjwu requested a review from cgmb February 1, 2024 17:12
@eidenyoshida
Copy link
Collaborator

@samjwu I added the docs team with write privilege

can you also add the original code owners to all the docs files?

@samjwu samjwu merged commit fae44ed into develop Feb 7, 2024
14 of 15 checks passed
@samjwu samjwu deleted the documentation-codeowners branch February 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants