[ROCM 5.7] fix default installation path on Windows #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes from the latest develop branch work for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is for the 5.7 branch because we need it for the ROCm 5.7 release on Windows.
It is unusual on Windows to install to
C:\Program Filesmanually. It requires Administrator privilege, which is not standard or not easily granted. Only applications managed by the Windows installer are allowed to install in that directory, andcmake installis not one of them.Installing tests in a custom directory given to CMake is also impossible when
HEADER_INSTALL_PREFIXis set toC:/Program Files. Moreover, the directoryC:\Program Filesis for 64-bit applications only. In the case of 32-bit, the installer should use theC:\Program Files (x86)directory instead.The separate PRs will add that change to the current development branch.