Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick to 6.0: Rename CMake package to ROCmCMakeBuildTools #152

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

lawruble13
Copy link
Collaborator

For discussion, see: Rename CMake package to ROCmCMakeBuildTools (#128).

Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see #49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer.

In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.

For discussion, see: Rename CMake package to ROCmCMakeBuildTools (ROCm#128).

Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see ROCm#49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer.

In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
@lawruble13 lawruble13 changed the title Rename CMake package to ROCmCMakeBuildTools (#151) Rename CMake package to ROCmCMakeBuildTools Oct 11, 2023
@lawruble13 lawruble13 changed the title Rename CMake package to ROCmCMakeBuildTools Cherrypick to 6.0: Rename CMake package to ROCmCMakeBuildTools Oct 11, 2023
Copy link
Collaborator

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this.

@cgmb
Copy link
Collaborator

cgmb commented Oct 11, 2023

Oh. I did want to note that making a cherry-pick, you can use the -x option to have git add a message noting the original commit it was picked from. Not a big deal, but I think it's nice information to include. No need to change this one, though. Maybe give it a try next time.

@lawruble13 lawruble13 merged commit c79f89a into ROCm:release-staging/rocm-rel-6.0 Oct 11, 2023
7 of 8 checks passed
@lawruble13
Copy link
Collaborator Author

Oh. I did want to note that making a cherry-pick, you can use the -x option to have git add a message noting the original commit it was picked from.

Thanks, I didn't know that! I'll be sure to use it in the future.

@cgmb
Copy link
Collaborator

cgmb commented Oct 12, 2023

@lawruble13, I reverted the cherry-pick due to failures in other components. This feature needs more time to bake. It's too late in the ROCm 6.0 development cycle to make changes that are potentially breaking for other components.

There wasn't a fundamental need to ship this in ROCm 6.0, aside from the paperwork involved with deferring it. If someone gives you a hard time on the deferral, refer them to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants