Minor CMake Changes #466
Open
Minor CMake Changes #466
+42
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlangbe
requested review from
a team,
cgmillette,
CongMa13 and
bragadeesh
as code owners
|
@dlangbe Docs changes look good, but do we need to update the changelog here too? (We did for hipTensor 303.) |
|
@dlangbe We should apply the feedback from hipTensor's PR to this one. Also need to target as ROCm 6.4 change |
cgmillette
reviewed
Dec 3, 2024
| ### Changed | ||
|
|
||
| * Renamed the CMake option `AMDGPU_TARGETS` to `GPU_TARGETS` | ||
|
|
||
| ## (Unreleased) rocWMMA 1.6.0 for ROCm 6.3.0 |
There was a problem hiding this comment.
Suggested change
| ## (Unreleased) rocWMMA 1.6.0 for ROCm 6.3.0 | |
| ## rocWMMA 1.6.0 for ROCm 6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Changed
AMDGPU_TARGETStoGPU_TARGETS.AMDGPU_TARGETSwill be deprecated in the future, but will work the same for the time being.-Removed the use of
CMAKE_NO_BUILTIN_CHRPATHwhen --offload-compress is supported.