Move restore user global state code to proper section #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleytsang-amd
requested review from
umfranzw,
RobsonRLemos and
lawruble13
as code owners
RobsonRLemos
approved these changes
Apr 11, 2025
NguyenNhuDi
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
LGTM. The location of restore user global state was missed in my last PR (#624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe #624 was incomplete in that it did not move the restore user global state code
rocRAND/cmake/Dependencies.cmake
Line 160 in 9203a70
to after the configuration of googletest and googlebenchmark.
This results in the tests and benchmarks to be built as shared libraries by default and not static libraries (which is how it worked before). This then requires googletest/bench libs to be installed on the system, which is not guaranteed and is causing issues in QA testing.
@NguyenNhuDi Please confirm if the location of the restore user global state code was intended by your PR.