Enable compatibility with projects using HIP language #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawruble13
requested review from
stanleytsang-amd,
umfranzw and
RobsonRLemos
as code owners
cgmb
reviewed
Feb 12, 2024
| if( CMAKE_CXX_COMPILER MATCHES ".*/hipcc$" ) | ||
| execute_process(COMMAND ${CMAKE_CXX_COMPILER} "--help" | ||
| OUTPUT_VARIABLE CXX_OUTPUT | ||
| if( CMAKE_${ROCRAND_LANG}_COMPILER MATCHES ".*/hipcc$" ) |
There was a problem hiding this comment.
hipcc cannot be used as the HIP language compiler.
Comment on lines
+61
to
+62
| get_property(ENABLED_LANGUAGES GLOBAL PROPERTY ENABLED_LANGUAGES) | ||
| if(HIP IN_LIST ENABLED_LANGUAGES) |
There was a problem hiding this comment.
Could we maybe just finish up #266 and suggest that users to set -DROCRAND_CMAKE_HIP_LANGUAGE=ON?
|
It would be good to fix this or #266. In the Spack package manager we're improving hip support by modeling it as a language, but I'm somewhat surprised that 4 years after CMake started support hip as a language, AMD's own packages do not use it 🤔 |
|
This pull request has merge conflicts that need to be resolved before I can automatically import this to the monorepo. |
|
Ditto Cory's comments on #266, this is still a desirable feature but this PR is very out of date and should probably be redone in its entirety. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a project tried to include rocRAND via
add_subdirectory, but was using theHIPlanguage provided by CMake, this would fail (see rocThrust issue #238). This PR should enable rocRAND to be used in this fashion.