Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port asan to 6.3.0.1 #520

Open
wants to merge 1 commit into
base: release/rocm-rel-6.3.0.1
Choose a base branch
from
Open

Port asan to 6.3.0.1 #520

wants to merge 1 commit into from
+63 −13

Conversation

malcolmroberts
Copy link
Contributor

No description provided.

@malcolmroberts
Improve address sanitizer build
fc0cedd 
When building with the address sanitizer option turned on:
Compile for xnack+ architectures when specifying address sanitizer build.
Add address sanitizer flags to runtime-compiled kernels.
Do not create a kernel cache.
evetsso
evetsso reviewed Oct 2, 2024
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,14 @@ Documentation for rocFFT is available at

## rocFFT 1.0.29 (unreleased)

### Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG entry is in wrong section.

amd-jnovotny
amd-jnovotny approved these changes Oct 13, 2024
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,14 @@ Documentation for rocFFT is available at

## rocFFT 1.0.29 (unreleased)

### Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Changes
### Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evetsso evetsso evetsso left review comments

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@pramenku pramenku Awaiting requested review from pramenku

@b-sumner b-sumner Awaiting requested review from b-sumner

@af-ayala af-ayala Awaiting requested review from af-ayala af-ayala is a code owner

@eng-flavio-teixeira eng-flavio-teixeira Awaiting requested review from eng-flavio-teixeira eng-flavio-teixeira is a code owner

@feizheng10 feizheng10 Awaiting requested review from feizheng10 feizheng10 is a code owner

@amd-aakash amd-aakash Awaiting requested review from amd-aakash

@whchung whchung Awaiting requested review from whchung

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malcolmroberts @evetsso @amd-jnovotny