-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last Batch Policy changes for file source reader #182
Merged
Merged
Changes from 250 commits
Commits
Show all changes
613 commits
Select commit
Hold shift + click to select a range
44a4d31
Remove the parse_config
swetha097 876c9ad
Merge remote-tracking branch 'swe_fork/audio_pr4' into swbs/audio/pr5
swetha097 9445e6c
Adding missed param in python unit tests
SundarRajan28 12b4801
Merge branch 'swbs/audio/pr5' into swbs/audio/pr6
SundarRajan28 69d2448
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
SundarRajan28 39b5f00
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
SundarRajan28 006d23f
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
SundarRajan28 a35f3a8
Merge branch 'swbs/audio/pr7' into swbs/audio/pr10
SundarRajan28 2b2a651
Fix error - Too many open files
swetha097 4caf56c
Merge branch 'swbs/audio/pr10' of https://github.com/swetha097/rocAL …
swetha097 6408a68
Fix slice fill values copy issue
fiona-gladwin e39b59b
Merge branch 'swbs/audio/pr10' of https://github.com/swetha097/rocAL …
fiona-gladwin 5302f9e
Fix file list path in API dataloader
fiona-gladwin e496f3a
Revert "Add Glob to CMakeLists.txt"
fiona-gladwin 5df0055
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/aud…
fiona-gladwin 7dc7092
Fix include headers for Audio files
fiona-gladwin 19e30cf
Fix copy data 2D
fiona-gladwin 34deb3b
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin 4c02dfb
Minor changes
fiona-gladwin e3f350f
Pass decoded data info to load routine instead of separate vectors
fiona-gladwin 67cda83
Update CHANGELOG.md
fiona-gladwin d36df07
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin 42c844d
Update CHANGELOG.md
fiona-gladwin 8b1c59f
Change swap_handle_time variable name in loader
fiona-gladwin 241ce67
Merge remote-tracking branch 'swe_fork/swbs/audio/pr2' into swbs/audi…
swetha097 07ba1f6
Update the changelog.md
swetha097 83513fb
Update ChangeLog.md
swetha097 31959c2
Merge branch 'swbs/audio/pr5' of https://github.com/swetha097/rocAL i…
swetha097 6fd3621
Update ChangeLog.md
swetha097 abc63c9
Merge branch 'swbs/audio/pr3' into audio_pr4
SundarRajan28 bb8908b
Update CHANGELOG.md
SundarRajan28 91fed39
Formatting changes
fiona-gladwin ee3606b
Merge branch 'audio_pr4' into swbs/audio/pr5
SundarRajan28 6a80714
Update doxygen comments
fiona-gladwin a19086b
Merge branch 'swbs/audio/pr5' into swbs/audio/pr6
SundarRajan28 689985d
Move file source reader from readers/image to readers folder
fiona-gladwin db758fd
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin 6bf44de
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
SundarRajan28 3d0f485
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
SundarRajan28 edf81ad
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
SundarRajan28 67190bf
Update README and add doxygen description
fiona-gladwin ffdcb0a
Update CMakeLists and README for audio test
fiona-gladwin b2de5f4
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin d000af0
Update README for audio test
fiona-gladwin 7415447
Minor fix
fiona-gladwin f6bffef
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/aud…
fiona-gladwin cb034b0
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin 6089040
Merge branch 'swbs/audio/pr7' of https://github.com/swetha097/rocAL i…
fiona-gladwin 568ee7e
Fix build errors
fiona-gladwin 2e38233
Fix Copy_Data_2d_ROI
swetha097 0e51f24
Merge branch 'swbs/audio/pr10' of https://github.com/swetha097/rocAL …
swetha097 d8031b5
Merge remote-tracking branch 'swe_fork/swbs/audio/pr2' into swbs/audi…
swetha097 d894aba
Fix merge from PR 2
swetha097 689c55f
Minor changes shard_count argument name
fiona-gladwin 1079d50
Rename set and get functions of data_info to decoded_data_info
fiona-gladwin 1f63cab
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin ff75ed9
Fix shard_size and audio source evaluation
94f6754
Changes in file_source_reader - to minimize the I/O operations
c082e9d
Changes in the variable name
5db5535
Changes in the variable names of the audio source evalution
2967b68
Merge branch 'swbs/audio/pr3' into audio_pr4
SundarRajan28 27429b3
Use set instead of vector
swetha097 d45967e
Minor bug fixes
swetha097 18baa2a
Minor fixes
fiona-gladwin dd2a7df
Fix drop policy without padding
fiona-gladwin a8f81d9
Fix pytorch iterator - PARTIAL policy
fiona-gladwin 9dab620
Merge branch 'swbs/audio/pr10' of https://github.com/swetha097/rocAL …
fiona-gladwin 36a9516
Merge branch 'audio_pr4' into swbs/audio/pr5
SundarRajan28 fb7a52b
Merge branch 'swbs/audio/pr5' into swbs/audio/pr6
SundarRajan28 b3823c8
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
SundarRajan28 4de03a5
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
SundarRajan28 0161204
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
SundarRajan28 42d1bb1
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr2
SundarRajan28 3375f41
Merge branch 'swbs/audio/pr2' into swbs/audio/pr3
SundarRajan28 d7c8884
Merge branch 'swbs/audio/pr3' into audio_pr4
SundarRajan28 513fd78
Merge branch 'audio_pr4' into swbs/audio/pr5
SundarRajan28 44cefd6
Merge branch 'swbs/audio/pr5' into swbs/audio/pr6
SundarRajan28 c100e80
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
SundarRajan28 9698308
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
SundarRajan28 23dad87
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
SundarRajan28 d928c48
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/aud…
fiona-gladwin c0d2309
Merge branch 'swbs/audio/pr1' into swbs/audio/pr2
fiona-gladwin c01325d
Revert empty line removed in CMakeLists.txt
fiona-gladwin 549def5
Removed prefix original for audio vectors
fiona-gladwin b8f90a8
Fix PARTIAL
fiona-gladwin 211c4c9
Reduce overall time for audio source evalution
swetha097 5a313ec
Fix shard_size and stick to shard issue seen with convergence
swetha097 c1d9cc5
Resolve PR comments
swetha097 7874f09
Add @params to all args in pytorch.py
swetha097 ef9a21b
Fix build issue
swetha097 0f48da9
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/aud…
fiona-gladwin a4de349
Merge branch 'swbs/audio/pr7' of https://github.com/swetha097/rocAL i…
fiona-gladwin 37921de
Minor changes in unit test
swetha097 96ace00
Merge branch 'swbs/audio/pr2' of https://github.com/swetha097/rocAL i…
swetha097 6602895
Minor changes
swetha097 aa13a35
Change ROCAL instaces to rocAL in pytorch.py
swetha097 2873d8c
Merge branch 'swbs/audio/pr2' into swbs/audio/pr3
fiona-gladwin 2dd31f8
Resolve the PR comments
swetha097 1cd9779
Merge branch 'swbs/audio/pr3' of https://github.com/swetha097/rocAL i…
swetha097 d1d5241
Minor changes in decoders.py - Modify the comment for shard_size
swetha097 f4bcbca
Merge branch 'swbs/audio/pr2' of https://github.com/swetha097/rocAL i…
fiona-gladwin d152dca
Merge branch 'swbs/audio/pr3' of https://github.com/swetha097/rocAL i…
fiona-gladwin e4c5788
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/aud…
fiona-gladwin 6a98227
Merge branch 'swbs/audio/pr10_training' into swbs/audio/pr10
swetha097 6279bb1
Fix shard_size
swetha097 fb33f06
Merge branch 'swbs/audio/pr3' into audio_pr4
SundarRajan28 be416ef
Minor changes
swetha097 d9dbd2c
Changes in pipeline.py and decoders.py
swetha097 b674564
Merge remote-tracking branch 'origin/swbs/audio/pr10_training' into s…
swetha097 8a7bb3c
Address the PR comments
swetha097 2021ab9
Address Review comments
swetha097 f3a1afa
Remove print statement
swetha097 08033c7
Merge branch 'swbs/audio/pr10' into lbp_fix_pr10
swetha097 33b3681
Fix the count_items
swetha097 261b2e7
Make Sharding similar to DALI
swetha097 bb2bad2
Fix issues with DROP policy by introducing a new vector for padding
swetha097 075882e
Minor fixes
swetha097 adbc5fd
Comment out print statements
swetha097 c304314
Add changes for shard_size LBP testing
swetha097 0524019
Fix DROP Policy with shard_size > 0
swetha097 a7eef66
Fix Stick_to_Shard=False
swetha097 0395ddd
Fix PARTIAL policy and code clean up
swetha097 63aacf6
fix last_batch_padded size when shard_size > 0
swetha097 0cb2812
Fix Drop policy - we skip the dropped batch in the next epoch
swetha097 296e1c6
Fix single shard outputs
swetha097 497cd08
Remove the commented code and fix the padding code in open()
swetha097 66addb9
Remove div by num_shards in decoders.py
swetha097 0c900a9
Introduce Audio layouts
fiona-gladwin e75616c
Add layout changes for spectrogram
fiona-gladwin e7ed0d8
Fix the unit tests - c++ & python
swetha097 528a87a
Merge branch 'swbs/audio/pr5' of https://github.com/swetha097/rocAL i…
fiona-gladwin feff5bd
Code clean up and formatting
swetha097 9b206a8
Minor code clean up
swetha097 4bc0f0d
code clean up in pytorch.py
swetha097 2809761
Add layout changes for spectrogram
fiona-gladwin 8ff55cb
Pass layouts for MelFilterBank
fiona-gladwin 0993896
Fix ToDecibels
fiona-gladwin 79d316c
Fix Normalize
fiona-gladwin 0822f76
Fix build issue
fiona-gladwin 120dddc
Merge branch 'swbs/audio/pr5_layout' of https://github.com/swetha097/…
fiona-gladwin a6cbbe2
Fix python unit test
fiona-gladwin 8be961b
Merge remote-tracking branch 'swe_fork/swbs/audio/pr7_layout' into sw…
swetha097 ab993d0
Minor fix
fiona-gladwin 1ddfe34
Pass LBP to decoders instead of the Pipeline creation
swetha097 d7764e1
Merge branch 'swbs/lbp_fixes_pr10_pass_readers' into swbs/lbp_fixes_pr10
484e1bd
Update pipeline.py - Remove commented code
swetha097 924ab79
Update pipeline.py - Remove commented out code
swetha097 9757256
Adding changes for spec layout changes
SundarRajan28 6b2a06c
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
SundarRajan28 df70d39
Merge branch 'swbs/audio/pr8' into swbs/audio/pr7
SundarRajan28 5505ed8
Adding changes to MFB and normalize nodes
SundarRajan28 e685c37
Update node_slice.cpp
swetha097 fc26afd
Update node_slice.h
swetha097 4320399
Resolve PR comments
swetha097 ce91644
Merge branch 'swbs/audio/pr5_layout' into swbs/audio/pr5
fiona-gladwin 60133c6
Merge branch 'swbs/audio/pr5' into swbs/audio/pr6
fiona-gladwin b2c40eb
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
fiona-gladwin 84db544
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
fiona-gladwin affe8f3
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
fiona-gladwin c41f363
Merge remote-tracking branch 'open_source/develop' into swbs/audio/pr3
swetha097 70e12cd
Merge branch 'swbs/audio/pr3' into audio_pr4
swetha097 b858b69
Merge branch 'audio_pr4' into swbs/audio/pr5
swetha097 5e79034
Merge remote-tracking branch 'origin/swbs/audio/pr5' into HEAD
swetha097 66be5a2
Merge branch 'temp_swbs/audio/pr6' into swbs/audio/pr6
swetha097 91c4fa1
Merge branch 'swbs/audio/pr6' into swbs/audio/pr8
swetha097 750b286
Merge branch 'swbs/audio/pr8' into swbs/audio/pr9
swetha097 5276ec2
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
swetha097 4e39f6a
Merge branch 'swbs/audio/pr7' into swbs/lbp_fixes_pr10
swetha097 ed9aae2
Fix downmix failing case and resolve the issue with merge
swetha097 74759dc
Fix issue with file_source_reader.cpp when file_list is not used
swetha097 a417f17
Resolve PR comments - Sundar
swetha097 a0242d9
Fix file_source_reader.cpp
swetha097 0f4a590
Fix shuffle issues
SundarRajan98 9b5fab1
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr7
SundarRajan28 328c41a
Adding comments to all if conditions
sbavasab 6237aaf
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
swetha097 11b0f96
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr7
SundarRajan28 83cecf5
Merge remote-tracking branch 'open_source/develop' into swbs/audio/pr9
swetha097 6692974
Fix merge conflicts
SundarRajan28 0cd21de
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr7
SundarRajan28 f7e8826
Merge remote-tracking branch 'open_source/develop' into develop
swetha097 00cdddb
Merge remote-tracking branch 'open_source/develop' into swbs/audio/pr9
swetha097 0c74d8b
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr7
SundarRajan28 20ef6d6
Resolving review comments
SundarRajan28 7e9b3ce
Merge branch 'develop' into swbs/audio/pr9
swetha097 7af1c03
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr9
SundarRajan28 e2ef16b
Merge branch 'swbs/audio/pr9' into swbs/audio/pr7
SundarRajan28 c3f5391
Merge remote-tracking branch 'upstream/develop' into swbs/audio/pr7
SundarRajan28 5b5348a
Merge remote-tracking branch 'swe_fork/swbs/audio/pr7' into swbs/lbp_…
swetha097 9b5edec
Fix a minor warning in file source reader
swetha097 5326625
Merge branch 'develop' into swbs/audio/pr7
LakshmiKumar23 c6fe840
Resolving review comments
SundarRajan28 5b4ebc5
LBP comments resolution
swetha097 c8e1791
Merge branch 'develop' into swbs/audio/pr7
LakshmiKumar23 704badd
Resolving review comments
SundarRajan28 e521768
Merge remote-tracking branch 'upstream/develop' into swbs/lbp_fixes_pr10
SundarRajan28 a902dca
Merge branch 'swbs/audio/pr7' into swbs/lbp_fixes_pr10
SundarRajan28 97d7077
Formatting changes
SundarRajan28 0ddea59
Resolving Final Set of PR comments
swetha097 13a105a
Combine with OR condition
swetha097 f189738
Remove the pad_last_batch_repeated print statement from decoders.py
swetha097 4e9ff04
Merge branch 'develop' of https://github.com/ROCm/rocAL into swbs/lbp…
fiona-gladwin 5d0decf
Add shard_size and stick_to_shard variables in args
swetha097 0b8f35c
Merge branch 'develop' into swbs/lbp_fixes_pr10
swetha097 0e5fa5a
Minor spelling fix
swetha097 769010c
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 615e12d
Make changes to insert the padded data in the file_names vector
swetha097 cec5e8a
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
swetha097 072ee56
Support to pass the variables fo lbp as struct
swetha097 408091a
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 78c2a3d
Fix segmentation fault
swetha097 4dcc1fc
Merge branch 'ROCm:develop' into swbs/lbp_fixes_pr10_pr_comments
SundarRajan28 e3ccc27
Merge branch 'swbs/lbp_fixes_pr10_pr_comments' into swbs/lbp_fixes_pr10
swetha097 1c5398e
Resolve PR comments
swetha097 4e003c3
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
swetha097 4ffb79b
Resolve PR comments
swetha097 70220c3
Resolve PR comments
swetha097 c58ffa9
Use PreComputed start and end indices
swetha097 6803069
Use precomputed shard_idx start and end in initialize
swetha097 a5797d5
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 68cbee9
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 4d83a11
Merge remote-tracking branch 'origin/swbs/lbp_fixes_pr10_pr_comments'…
swetha097 4a5b55f
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 99d232d
Initialize the Sharding info using ShardingInfo()
swetha097 e9b5d63
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
swetha097 612b450
convert the signed to int32_t type
swetha097 85d2c2a
temp commit for struct changes
swetha097 1c1dfa8
Fix the struct changes - All the test cases passing
9e1ce0c
Remove any print statements
85ef52a
Add support to Pass the decode size policy from the user
6e1b81f
Add support to Pass the decode size policy from the user
be92088
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
swetha097 51259c3
Rename RocalShardingInfo for ShardingInfo and vice-versa
swetha097 7b4276f
xywh roi copy
swetha097 8157375
Fix decoders.py for image decoders
swetha097 673b5d5
Make stick_to_shard True by default
swetha097 dea2023
Merge branch 'develop' of https://github.com/ROCmSoftwarePlatform/roc…
fgladwin 8ae2e1c
Minor changes to the copy_data function
swetha097 8e26013
Rename to x_offset and y_offset in copy_data
fgladwin 125c093
Minor changes - remove unused variables
fgladwin bf6f72f
Minor change - Variable names
fgladwin 4560ffc
Update Doxygen comments and comments of API
fgladwin 81c9d19
Merge branch 'swbs/lbp_fixes_pr10' of https://github.com/swetha097/ro…
fgladwin f279dc5
Merge branch 'develop' into swbs/lbp_fixes_pr10
LakshmiKumar23 bf1c23a
Merge branch 'develop' into swbs/lbp_fixes_pr10
kiritigowda 82e276f
Make the rocalShardingInfo as the last param for Audio loaders
2918a89
Remove unused variables and functions in file_source_reader.cpp & .h …
0878361
Remove the doctring explanation for unused params
2c1aee9
Change the explanation according to the newly introduced structure
753e442
Merge branch 'develop' into swbs/lbp_fixes_pr10
LakshmiKumar23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why mem_type is removed?
instead of max_cols and max_rows, I prefer passing an roi with (xoff, yoff, w, h)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mem_type support will be enabled as a part of the API when the HIP support for the augmentations will be added.