Add softmaxcrossentropy op #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
force-pushed
the
add_softmaxcross_entropy_op
branch
from
4048831 to
36cd087
Compare
TedThemistokleous
merged commit 8db3c3d
into
rocm6.3_internal_testing
16 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the softmaxcrossentropyloss operator - Remove the check for op as not supported
Update MIGraphX EP check for supported ops by leveraging API call we use in
migraphx-driver onnx --listto get a list of supported onnx parsers built into MIGraphX. Stops us from having to continually update the EP when a new operator is addedNow things should auto updated automatically.
Motivation and Context
Used for runs with LlamaV2 and above. Allows us to run this fully in GPU.
Wont merge until: ROCm/AMDMIGraphX#3008 is merged into MIGraphXShould be fine to merge with latest change should it work. Will test end to end once other PR merged.