Remove default noopt for migraphx. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
merged commit 8a43be8
into
rocm6.2_internal_testing
11 of 14 checks passed
TedThemistokleous
added a commit
that referenced
this pull request
Aug 23, 2024
…ripts (#58) Co-authored-by: Ted Themistokleous <[email protected]>
TedThemistokleous
added a commit
that referenced
this pull request
Aug 23, 2024
…ripts (#58) (#59) Co-authored-by: Ted Themistokleous <[email protected]>
TedThemistokleous
added a commit
that referenced
this pull request
Aug 26, 2024
…ripts (#58) Co-authored-by: Ted Themistokleous <[email protected]>
TedThemistokleous
added a commit
that referenced
this pull request
Aug 26, 2024
…ripts (#58) (#60) Co-authored-by: Ted Themistokleous <[email protected]>
jagadish-amd
pushed a commit
to jagadish-amd/onnxruntime
that referenced
this pull request
Sep 10, 2024
…k.py (microsoft#21843) …ripts (ROCm#58) ### Description <!-- Describe your changes. --> Removes the heavy handed no opt for all MIGraphX using the benchmark.py scripts ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Finding this hurts performance if we remove all optimizations. Let the fine tuning occur at the script level instead of a blanket NoOPT being selected Co-authored-by: Ted Themistokleous <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default all no_opt is too heavy handed here. Finding its hurting performance on other scripts . Adding this option on scripts that QA said were failing
Motivation and Context
Fixes issues with BLAS that occurred with transpose