AMDGPU: Use promotion to f32 path for log/log10 for f16 by default#1371
AMDGPU: Use promotion to f32 path for log/log10 for f16 by default#1371arsenm wants to merge 1 commit intoamd-stagingfrom
Conversation
While the current implementation passes OpenCL conformance, it is not correctly rounded with an error of 1.79 ulp according to the conformance test. Default to the promotion path without afn. In the future we should make use of !fpmath metadata but that's not wired into the backend, or from any frontend producer.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
2 participants
While the current implementation passes OpenCL conformance, it is not correctly rounded with an error of 1.79 ulp according to the conformance test. Default to the promotion path without afn. In the future we should make use of !fpmath metadata but that's not wired into the backend, or from any frontend producer.