Add SpGEMM estimate memory routine #462
Open
+269
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsandham
requested review from
a team,
ntrost57 and
YvanMokwinski
as code owners
ntrost57
reviewed
Apr 22, 2024
|
|
||
| if(externalBuffer3 == nullptr) | ||
| { | ||
| *bufferSize3 = 4; |
There was a problem hiding this comment.
If I put 0 then the externalBuffer3 will remain nullptr as nothing will be allocated and therefore we will never enter the else branch.
There was a problem hiding this comment.
mmhm I see. I do not really like that.. but I guess we probably have to live with it.
ntrost57
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing SpGEMM estimate memory routine that was added to cuSPARSE 12.0.1