Add CMake support for documentation #77
Open
+62
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyas-streamhpc
force-pushed
the
add-cmake-doc
branch
2 times, most recently
from
5a0bc21 to
a42d1e6
Compare
matyas-streamhpc
force-pushed
the
add-cmake-doc
branch
from
a42d1e6 to
7101aa5
Compare
matyas-streamhpc
requested review from
af-ayala,
eng-flavio-teixeira,
evetsso,
feizheng10 and
malcolmroberts
as code owners
matyas-streamhpc
force-pushed
the
add-cmake-doc
branch
from
7101aa5 to
3a203e0
Compare
|
Rebased |
malcolmroberts
approved these changes
Sep 3, 2024
eng-flavio-teixeira
approved these changes
Sep 3, 2024
af-ayala
approved these changes
Sep 3, 2024
evetsso
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
@matyas-streamhpc Can you please fix the items I've commented on? I'll be able to merge this once they're finished.
Sorry for the long delay in getting around to this PR.
| @@ -27,6 +27,7 @@ Documentation for hipFFT is available at | |||
|
|
|||
| * `hipfftXtSetGPUs`, `hipfftXtMalloc, hipfftXtMemcpy`, `hipfftXtFree`, and `hipfftXtExecDescriptor` APIs | |||
| have been implemented to allow FFT computing on multiple devices in a single process | |||
| * CMake support for documentation. | |||
There was a problem hiding this comment.
Can you merge current develop into this branch, and then make this an Addition under hipFFT 1.0.17? i.e.
## hipFFT 1.0.17 (unreleased)
### Additions
* CMake support for documentation.| Alternatively, build with CMake: | ||
|
|
||
| ```bash | ||
| cmake -DBUILD_DOCS=ON ... |
amd-jnovotny
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #___
Summary of proposed changes: