Verify toolchain components at program invocation #1413
+387
−392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is code spread around TensileLt for verifying the selected toolchain, such as checking if a requested compiler is supported, finding the path to the compiler, checking if the offload bundler can be found, and verifying it is executable, among others. Since the toolchain is fixed throughout the execution of Tensile, TensileCreateLibrary, and other programs in the TensileLt project, moving shared toolchain validation logic to a module that is called once in the setup phase of each program improve the maintainability and clarity of the code, but more importantly eliminates occurrences whereby a program crashes several minutes (or more) into its execution because of an improper toolchain component.
Outcomes
Principles
In an effort to improve coding standards for future developments to hipBLASLt, the following principles were followed when implementing this PR.
Testing