Refactoy the pack scheduling for scheduleIterAlg = 3. #1358
+204
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vin-huang
requested review from
jichangjichang,
KKyang,
aazz44ss,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
vin-huang
force-pushed
the
pop_pack_in_rr
branch
from
2a5d3cc
to
14bd624
Compare
vin-huang
changed the title
vin-huang
force-pushed
the
pop_pack_in_rr
branch
2 times, most recently
from
0450d7f
to
2036a35
Compare
* Used 3 different pack pools to store the pack instructions of A, B, and Metadata
* Step 1, only put the required pack into the code (the number of required packs may differ for each mfma iteration).
check if the inserted pack is forfulled the instPerPack, if not insert next pack instructions until statisfied.
Step 2, if there still have room before mfma, then insert next pack instructions (#instPerPack)
Step 3, put another pack or SNop before the mfma instruction according to the needed latency. the combination of insertion may be 2 packs, 1 pack + snop 0, or snop 1.
vin-huang
force-pushed
the
pop_pack_in_rr
branch
from
2036a35
to
76ab700
Compare
…scheduleIterAlg = 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three tracks for the sparse MM.
so, needed to make sure the pack items that are required will be poped in each iter.
[idea]
check if the inserted pack is forfulled the instPerPack, if not insert next pack instructions until statisfied.
Step 2, if there still have room before mfma, then insert next pack instructions (the # of instruction that going to be inserted will same as #instPerPack)
Step 3, put another pack or SNop before the mfma instruction according to the needed latency. the combination of insertion may be 2 packs, 1 pack + snop 0, or snop 1.