Fix SIGSEGV when compiled with -march=znver4 #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in _mm512_stream_si512 (which requires 64-aligned allocations, but used to copy default-aligned objects). As it is seemingly difficult to change allocations for copied objects (common objects with ref-counts), the fix just replaces nontemporalMemcpy with normal memcpy, which is already optimized in most versions of C runtime. Closes ROCm#18
|
Thank you @AngryLoki for raising this. There is a PARAMETERS_MIN_ALIGNMENT in https://github.com/ROCm-Developer-Tools/clr/blob/develop/rocclr/utils/flags.hpp#L55 that is set to 16 in 5.7.0 and I suspect it causes the issue. |
|
@iassiour , thanks, it worked, I've replaced patch in Gentoo to gentoo/gentoo@6648534#diff-29d328ef381c60ad2e9731756f2d3c0465678976b91ef2bb5d2b63f45e05b9e0 . So as there is nothing to do for develop branch (because it contains 64 for all targets), I'll close this pull-request, but I'd like to see a permanent fix for #18 in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to unaligned allocations, library crashes in nontemporalMemcpy in _mm512_stream_si512 (which requires 64-aligned allocations, but used to copy default-aligned objects).
As it is seemingly difficult to change allocations for copied objects (common objects with ref-counts), the fix just replaces nontemporalMemcpy with normal memcpy, which is already optimized in most versions of C runtime.
Closes #18