Skip to content

Implement ImageTransform #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 47 commits into
base: develop
Choose a base branch
from
Open

Implement ImageTransform #3621

wants to merge 47 commits into from
+5,251 −3

Conversation

cognaiger9
Copy link
Collaborator

@cognaiger9 cognaiger9 commented Mar 14, 2025 •
edited
Loading

Add ImageTransform kernels:

  • ImageAdjustBrightness (ImageAdjustBrightnessFwdContiguous)
  • ImageAdjustHue (Including ImageAdjustHue and ImageAdjustHuecontiguous)
  • ImageAdjustSaturation (RGBToGrayscale, RGBToGrayscaleContiguous, BlendContiguous)
  • ImageNormalize (ImageNormalizeFwdContiguous)

Detailed performance results are here

Average performance:

ImageAdjustBrightness

contiguous
float32 3.72
float16 3.15
bfloat16 3.33

ImageAdjustHue

contiguous noncontiguous
float32 190.43 28.16
float16 197.85 32.91
bfloat16 214.06 32.18

ImageAdjustSaturation

contiguous
float32 5.21
float16 2.43
bfloat16 2.34

ImageNormalize

contiguous
float32 1.97
float16 18.14
bfloat16 1.89

o2buzzle added 30 commits June 6, 2024 17:19
@o2buzzle
added: ImageTransform/ImageAdjustHue
94c6aed
@o2buzzle
fix: change adjust_hue algo network config
f270501
@o2buzzle
added: some consistency checks
87944ce
@o2buzzle
chore: reorganization
9867dcd
@o2buzzle
added: ImageAdjustBrightness kernels
e49a822
@o2buzzle
added: gpu driver code for ImageAdjustBrightness
f4cb83e
@o2buzzle
fixed: re-organized tensor_view
0de84f9
@o2buzzle
fix: memory access issue
d8284de
@o2buzzle
fix: non-contiguous imagehue
38dd6bc
@o2buzzle
added: ImageNormalize kernel and bootstrap code
9584f28
@o2buzzle
added: driver code for ImageNormalize
ffe63ae
@o2buzzle
added: kernel bootstrap code for ImageAdjustSaturation and ImageAdjus…
141836c 
…tContrast
@o2buzzle
added: driver and verification for ImageAdjustSaturation
808e612
@o2buzzle
fixed: remove debug output
9fe33a4
@o2buzzle
added: gtest unit tests for image_adjust_hue
e965389
@o2buzzle
added: image adjust brightness test
4c93f3d
@o2buzzle
added: image_adjust_saturation tests
3e86e37
@o2buzzle
added: image normalize tests
9d4ac0d
@o2buzzle
added: filter performant cases
95491b9
@o2buzzle
fix: add threashold for fp16
9b74434
@o2buzzle
fix[test]: mark header functions as inline
1d93ebb
@o2buzzle
fix: remove non-functional Contrast APIs
21c410d
@o2buzzle
fix[driver]: make input random again
c527be4
@o2buzzle
fix[driver]: Switch to rms_range
e8ef154
@o2buzzle
fix: remove comment from kernel
7a342da
@o2buzzle
fix: remove unused arguments in host code
2bc4cd7
@o2buzzle
fix: remove miopen.h autoformat error
f18e95f
@o2buzzle
fixed: cmakelists order
78e46e8
@o2buzzle
fixed: n=1 comments
526317e
@o2buzzle
fixed: throw instead of assert
e5fd34f
o2buzzle and others added 17 commits June 21, 2024 15:58
@o2buzzle
fix: use numeric_limits::epsilon instead of static values
0ff5125
@o2buzzle
fix: add saturation factor check
31b8d13
@o2buzzle
fix: add fp16 and bfp16 unit tests
db99e0c
@o2buzzle
added: Image Normalize checks
7784949
@o2buzzle
fixed: renamed internal miopen calls
d1f7908
@o2buzzle
fix: remove mentions of ImageAdjustContrast
9ff443f
@o2buzzle
fixed: remove nchw kernels
5861d2a
@o2buzzle
fix: remove commented code
a362e03
@o2buzzle
removed: Unused kernels
5df6a04
@o2buzzle
fixed(adjust_saturation): GetWorkspace return null for workspace_buf
9c4408d
@o2buzzle
fix: remove custom clamp implementation for stdc++ clamp
7b27217
@o2buzzle
fix: remove underscores in driver names
323ef3c
@o2buzzle
fix: make adjust_saturation only work on color images
b497c28
@cognaiger9
Merge branch 'develop-moreh' of https://github.com/moreh-dev/MIOpen i…
05cfd93 
…nto impl_imagetransform
@cognaiger9
change skeleton and driver
190b238
@cognaiger9
add gtest
a181d53
@cognaiger9
Merge branch 'develop' of https://github.com/ROCm/MIOpen into impl_im…
717e79b 
…agetransform
@cognaiger9 cognaiger9 marked this pull request as ready for review March 14, 2025 06:42
@cognaiger9 cognaiger9 self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianHarrisonAMD BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

@BradPepersAMD BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

@adickin-amd adickin-amd Awaiting requested review from adickin-amd adickin-amd is a code owner

@JonathanLichtnerAMD JonathanLichtnerAMD Awaiting requested review from JonathanLichtnerAMD JonathanLichtnerAMD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cognaiger9 cognaiger9

Labels
enhancement external_collaborator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognaiger9 @o2buzzle