Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rjs/rk gtc #3452

Open
wants to merge 13 commits into
base: rk_gtestchecker
Choose a base branch
from
Open

rjs/rk gtc #3452

wants to merge 13 commits into from
+2,310 −526

Conversation

randyspauldingamd
Copy link
Contributor

Helping with #3370

  • Merged develop into Reid's branch
  • Refactored the easier outliers
  • Made keyword detection more robust by requiring word boundary

AngryLoki and others added 13 commits December 24, 2024 12:20
@AngryLoki
Fix missing isnan definition on libstdc++ >=14 systems (#3448)
d5641f7 
Closes #3441
@Vsevolod1983
[GTests] Rename non-unique test names (TEST, TEST_P, TEST_F, TYPED_TE…
677a9bc 
…ST). Part 1. (#3446)

 Rename non-unique test names Part 1
@dependabot
Bump rocm-docs-core[api_reference] from 1.11.0 to 1.12.0 in /docs/sph…
d172672 
…inx (#3439)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.11.0...v1.12.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@scerzh
[BUG] Fix memory leak in GraphExecutorFind20 (#3428)
f3856e5 
* Fix memory leak in GraphExecutorFind20

* Add scope_exit for finally

* remove debug code

* Add pragma to the header

* Add assert messages

* Delete copy-constructor

* Fix clang-format
@scerzh
[GRAPHAPI] Implement MIOPEN_BACKEND_EXECUTION_PLAN_DESCRIPTOR Seriali…
60a7c7d 
…zation (#3430)

* Fix memory leak in GraphExecutorFind20

* Implement JSON attribute of CUDNN_BACKEND_EXECUTION_PLAN_DESCRIPTOR

* Fix failed test graphapi_engine

* Fix Smoke/GPU_MhaBwdGraphTest_FP32.MhaBwdGraph test

* Move base64 staff to a dedicated header
@Vsevolod1983
[GTests] Rename non-unique test names (TEST, TEST_P, TEST_F, TYPED_TE…
ec5dadb 
…ST). Part 2. (#3449)

[GTests] Rename non-unique test names (TEST, TEST_P, TEST_F, TYPED_TEST). Part 2
@Vsevolod1983
[GTests] Rename non-unique test names. Part 3 (#3450)
75ea67e 
[GTests] Rename non-unique test names. Part 3
@novakovicdj @CAHEK7
Initial porting of Op4dTensorGeneric (#3404)
532bf75 
* initial changes

* fixing parameters for Op4dTensorGeneric kernel

* minor changes

* minor changes for hip tidy

---------

Co-authored-by: Alex Eremin <[email protected]>
@randyspauldingamd
Merge remote-tracking branch 'origin/develop' into rjs/rk_gtc
005b0a6
@randyspauldingamd
refactor layout_transpose
99fd6e7
@randyspauldingamd
reduce_custom_fp32 is ok
809b9ed
@randyspauldingamd
refactor graphapi_conv...fwd
1f0f6d6
@randyspauldingamd
fix graphapi_operation_rng; fix word boundary bug
cdcd6fb
@randyspauldingamd randyspauldingamd mentioned this pull request Jan 2, 2025
Open
reidkwja
reidkwja reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@reidkwja reidkwja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires clang formatting for the CI to pass

@randyspauldingamd
Copy link
Contributor Author

Requires clang formatting for the CI to pass

This is intended to be merged into your branch and merged into develop along with your other changes. It does not require an extra CI run on its own. If you don't want to mess with the other changes, that's ok, we can merge those separately later. At a minimum though, add the word boundary checks since the logic is incorrect without them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidkwja reidkwja reidkwja left review comments

@BrianHarrisonAMD BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

@junliume junliume Awaiting requested review from junliume

@BradPepersAMD BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@randyspauldingamd @reidkwja @AngryLoki @Vsevolod1983 @scerzh @novakovicdj