[gfx1250][gemm] Make mxscale B-scale preshuffle tile-independent#679
Draft
aoli26 wants to merge 13 commits into
Draft
[gfx1250][gemm] Make mxscale B-scale preshuffle tile-independent#679aoli26 wants to merge 13 commits into
aoli26 wants to merge 13 commits into
Conversation
- runtime: capture cluster kernels into hipGraph nodes via hipGraphAddKernelNode, relying on baked-in amdgpu-cluster-dims (graph-node cluster attribute is unsupported on this HIP build) - test: parametrize test_mxscale_gemm_cudagraph with cluster cases; run functional test through hipGraph (graph vs ref) when --use-graph is set, covering --use-graph and --benchmark --use-graph --verify
aoli26
force-pushed
the
gfx1250/gemm_exp_aoli
branch
from
7038717 to
dc49c0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Decouple gfx1250 MXScale B-scale preshuffle from GEMM tile shape, and keep A-scale on an independent path instead of tying it to the new B-scale layout.
Technical Details
Test Plan
python3 -m pytest tests/kernels/test_gemm_fp8fp4_gfx1250.pyTest Result
All tests passed.
Submission Checklist