-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalar multiplication and followed by conv #3478
base: develop
Are you sure you want to change the base?
Scalar multiplication and followed by conv #3478
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3478 +/- ##
===========================================
- Coverage 92.02% 91.98% -0.04%
===========================================
Files 509 509
Lines 21005 21034 +29
===========================================
+ Hits 19330 19349 +19
- Misses 1675 1685 +10 ☔ View full report in Codecov by Sentry. |
…e-horizontal-fusion-opportunities
381540b
to
69457bd
Compare
@@ -744,7 +744,8 @@ struct find_unary_shape_transforms | |||
{ | |||
return ins->name() == "@literal" or | |||
ins->get_operator().attributes().contains("pointwise") or | |||
contains(ins->name(), "reduce"); | |||
contains(ins->name(), "reduce") or | |||
ins->get_operator().attributes().contains("scalar"); //For scalar operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What operators have a scalar
attribute?
Unit tests needs to be added. |
src/simplify_algebra.cpp
Outdated
match::either_arg(0, 1)( | ||
match::is_constant().bind("scalar"), | ||
match::name("convolution").bind("conv") | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be checking for slice -> mul -> add. There is no reason to check for convolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in the apply
method you need to check the other slices go into add or mul -> add.
This reverts commit 69457bd.
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
No description provided.