-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push mlir commit cash to /.mlir-commit similar to how we manage onnxrt Sha-1 #1988
Conversation
…t sha-1s Do this so we have a central place for the MLIR commit sha-1 used between docker containers. useful for later once we have stuff for other OS versions and Distros Current use case is for 22.04 and regular Dockerfile being out of sync, causing build issues for the 22.04 build.
Codecov Report
@@ Coverage Diff @@
## develop #1988 +/- ##
========================================
Coverage 91.38% 91.38%
========================================
Files 422 422
Lines 15665 15665
========================================
Hits 14315 14315
Misses 1350 1350 |
This build is OK for merge ✅ |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output |
We should just put this in mlir-requirements.txt until it becomes part of requirements.txt. |
I dont understand this. We dont have mlir-requirements.txt here. Do you mean rename this? |
Change dockerfiles accordingly for this as well
6cd5f35
to
51f15d9
Compare
Done |
seems like an odd bunch of failures:
|
fba0428
to
6947444
Compare
add the . so its skipped via license checking.
Do this so we have a central place for the MLIR commit sha-1 used between docker containers.
useful for later once we have stuff for other OS versions and Distros
Current use case is for 22.04 and regular Dockerfile being out of sync, causing build issues for the 22.04 build.