Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push mlir commit cash to /.mlir-commit similar to how we manage onnxrt Sha-1 #1988

Closed
wants to merge 7 commits into from
Closed

Push mlir commit cash to /.mlir-commit similar to how we manage onnxrt Sha-1 #1988

wants to merge 7 commits into from

Conversation

TedThemistokleous
Copy link
Collaborator

Do this so we have a central place for the MLIR commit sha-1 used between docker containers.

useful for later once we have stuff for other OS versions and Distros

Current use case is for 22.04 and regular Dockerfile being out of sync, causing build issues for the 22.04 build.

@TedThemistokleous
Push mlir commit cash to /.mlir-commit similar to how we manage onnxr…
5c53349 
…t sha-1s

Do this so we have a central place for the MLIR commit sha-1 used between docker
containers.

useful for later once we have stuff for other OS versions and Distros

Current use case is for 22.04 and regular Dockerfile being out of sync, causing
build issues for the 22.04 build.
@TedThemistokleous TedThemistokleous added bug Something isn't working dependencies Pull requests that update a dependency file Continous Integration Pull request updates parts of continous integration pipeline labels Jul 20, 2023
@TedThemistokleous TedThemistokleous self-assigned this Jul 20, 2023
@TedThemistokleous TedThemistokleous linked an issue Jul 20, 2023 that may be closed by this pull request
put mlir sha-1 into file #1987
Open
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #1988 (2e29ccb) into develop (aeb9f78) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e29ccb differs from pull request most recent head 235ec64. Consider uploading reports for the commit 235ec64 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1988   +/-   ##
========================================
  Coverage    91.38%   91.38%           
========================================
  Files          422      422           
  Lines        15665    15665           
========================================
  Hits         14315    14315           
  Misses        1350     1350

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jul 21, 2023 •
edited
Loading

Test Batch Rate new
058cee		 Rate old
04ae9b		 Diff Compare
torchvision-resnet50 64 2,276.45 2,276.69 -0.01% ✅
torchvision-resnet50_fp16 64 5,338.81 5,330.98 0.15% ✅
torchvision-densenet121 32 1,823.39 1,824.31 -0.05% ✅
torchvision-densenet121_fp16 32 3,370.60 3,367.05 0.11% ✅
torchvision-inceptionv3 32 1,348.25 1,344.65 0.27% ✅
torchvision-inceptionv3_fp16 32 2,522.92 2,531.51 -0.34% ✅
cadene-inceptionv4 16 675.66 677.03 -0.20% ✅
cadene-resnext64x4 16 589.11 588.32 0.14% ✅
slim-mobilenet 64 7,220.56 7,217.40 0.04% ✅
slim-nasnetalarge 64 236.01 236.01 0.00% ✅
slim-resnet50v2 64 2,453.27 2,455.52 -0.09% ✅
bert-mrpc-onnx 8 718.84 718.69 0.02% ✅
bert-mrpc-tf 1 363.68 363.03 0.18% ✅
pytorch-examples-wlang-gru 1 305.72 309.84 -1.33% ✅
pytorch-examples-wlang-lstm 1 314.92 317.18 -0.71% ✅
torchvision-resnet50_1 1 559.42 555.26 0.75% ✅
torchvision-inceptionv3_1 1 305.78 307.06 -0.42% ✅
cadene-dpn92_1 1 349.64 346.25 0.98% ✅
cadene-resnext101_1 1 220.06 220.01 0.02% ✅
slim-vgg16_1 1 223.54 223.84 -0.13% ✅
slim-mobilenet_1 1 1,477.97 1,482.99 -0.34% ✅
slim-inceptionv4_1 1 224.25 224.66 -0.18% ✅
onnx-taau-downsample 1 321.03 321.02 0.00% ✅
dlrm-criteoterabyte 1 21.65 21.65 -0.02% ✅
dlrm-criteoterabyte_fp16 1 40.59 40.57 0.03% ✅
agentmodel 1 5,975.61 5,943.57 0.54% ✅
unet_fp16 2 55.00 55.09 -0.17% ✅

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jul 21, 2023 •
edited
Loading


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@TedThemistokleous TedThemistokleous added the skip bot checks Skips the Performance and Accuracy CI tests label Jul 21, 2023
@pfultz2
Copy link
Collaborator

pfultz2 commented Jul 23, 2023

We should just put this in mlir-requirements.txt until it becomes part of requirements.txt.

@TedThemistokleous
Copy link
Collaborator Author

TedThemistokleous commented Jul 27, 2023 •
edited
Loading

We should just put this in mlir-requirements.txt until it becomes part of requirements.txt.

I dont understand this. We dont have mlir-requirements.txt here. Do you mean rename this?

@TedThemistokleous
Move .mlir-commit to mlir-requirements.txt
51f15d9 
Change dockerfiles accordingly for this as well
@TedThemistokleous
Copy link
Collaborator Author

We should just put this in mlir-requirements.txt until it becomes part of requirements.txt.

Done

@TedThemistokleous
Copy link
Collaborator Author

seems like an odd bunch of failures:

Unable to create live FilePath for rocm-framework-33; rocm-framework-33 was marked offline: Disconnected by z1_miciadmin : cliinfofailure

pfultz2
pfultz2 requested changes Jul 31, 2023
View reviewed changes
mlir-requirements.txt Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
tools/docker/ubuntu_2204.dockerfile Outdated Show resolved Hide resolved
@pfultz2
Copy link
Collaborator

pfultz2 commented Aug 5, 2023

This is no longer needed after #2037 is merged. It would be better to just merge that PR instead as this will cause merge conflicts with #2037.

@TedThemistokleous
Copy link
Collaborator Author

This is no longer needed after #2037 is merged. It would be better to just merge that PR instead as this will cause merge conflicts with #2037.

Understood, closing

@TedThemistokleous TedThemistokleous mentioned this pull request Aug 5, 2023
Open
@causten causten deleted the update_mlir_to_file branch September 8, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfultz2 pfultz2 pfultz2 requested changes

@kahmed10 kahmed10 kahmed10 approved these changes

@umangyadav umangyadav umangyadav approved these changes

@causten causten Awaiting requested review from causten causten is a code owner

Assignees

@TedThemistokleous TedThemistokleous

Labels
bug Something isn't working Continous Integration Pull request updates parts of continous integration pipeline dependencies Pull requests that update a dependency file skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

put mlir sha-1 into file
5 participants
@TedThemistokleous @migraphx-bot @pfultz2 @kahmed10 @umangyadav