boards/seeedstudio-xiao-esp32s3: Add Initial Support [new PR] #21829
+463
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crasbe
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
crasbe
added
the
State: WIP
crasbe
added
Type: new feature
github-actions
bot
added
Area: doc
crasbe
added
CI: no fast fail
crasbe
force-pushed
the
pr/seeedstudio-xiao-esp32s3
branch
from
8a48a00 to
4fabe4b
Compare
crasbe
force-pushed
the
pr/seeedstudio-xiao-esp32s3
branch
from
a0faaad to
18eea9b
Compare
crasbe
removed
the
State: WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a takeover from #20973 as the original author unfortunately did not address the review comments and did not move this forward :(
I applied the typical style comments and most of the review comments except for the GPIO stuff that is still commented out.
This will need a bit of a deeper dive into the datasheet/schematic which I did not do yet.
Testing procedure
tests/sys/shellworks (except for the known issue with the output being truncated)tests/periph/pwmworkstests/periph/adcworkstests/periph/i2cscan works, I don't have any I2C devices aroundtests/periph/spibenchmark appears to worktests/ledsworksIssues/PRs references
This is a follow-up from #20973.