Skip to content

cpu/stm32: fix _ccmram_length name, make names consistent #21797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cpu/stm32: fix _ccmram_length name, make names consistent #21797

wants to merge 1 commit into from

Conversation

@crasbe
Copy link
Contributor

@crasbe crasbe commented Oct 15, 2025

Contribution description

The Linkerscript used a variable called _ccmram_len, while the Makefile defined it as _ccmram_length, therefore it was never actually used.

I also renamed fmc_ram_len to fmc_ram_length to make it consistent with the other two.

Testing procedure

Honstly I'm not sure how to test that?

I checked that no old names are left in the codebase:

RIOT$ grep -Rnw . -e fmc_ram_len
RIOT$ grep -Rnw . -e _ccmram_len

Will test it with real hardware

Issues/PRs references

Closes #21698.

@crasbe crasbe requested a review from aabadie as a code owner October 15, 2025 12:14
@crasbe crasbe added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Oct 15, 2025
@crasbe crasbe requested a review from vincent-d as a code owner October 15, 2025 12:14
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2025
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels Oct 15, 2025
@crasbe
Copy link
Contributor Author

crasbe commented Oct 15, 2025

@Sleader-m1 would you mind checking if this solves your issue?

@riot-ci
Copy link

riot-ci commented Oct 15, 2025

Murdock results

✔️ PASSED

e2a6122 cpu/stm32: fix _ccmram_length name, make names consistent

Success Failures Total Runtime
10515 0 10516 09m:25s

Artifacts

@crasbe
Copy link
Contributor Author

crasbe commented Oct 15, 2025

The bug was initially introduced in #7799 (eight years ago!). Also #19842 caught the missing underscore, but didn't catch the ccmram_len <-> ccmram_length.

@crasbe crasbe requested review from benpicco and gschorcht October 15, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@benpicco benpicco Awaiting requested review from benpicco

@gschorcht gschorcht Awaiting requested review from gschorcht

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CCMRAM for stm32 misprint

2 participants

@crasbe @riot-ci