-
Notifications
You must be signed in to change notification settings - Fork 2.1k
cpu/stm32/periph/fdcan: reread bittiming max values #21757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I have a Nucleo-G474, how could I test this? |
If you also got a can interface. |
another way of verifying that this does what i claim would be to enable debug in |
I just improved on the debug result print in #21756 that might help with the review |
the 1024 might have been read from a sentence in the manual in that process the MCAN BTP register names where where chaged from BTP an FBTP (FD Dataphse) to NBTP (Nominal) and DBTP (FD Dataphase) I am not sure if any of the G0 G4 was produced with an old mcan ip core (but even in that case the values would be wrong |
since the stm32 fdcan is quiet similar to the samd5 can (same ip core bosch mcan). i had a look at its configurartion and found the values quiet strage i reread them from the manual of stm32g0 and g4 (same) chapter 36 and 44 register (FDCAN_NBTP) and (FDCAN_DBTP)
especially the SJW values where strange.
Contribution description
update the bittiming max values to the values actually found in the manual
Testing procedure
read and compare
test with hardware
i do not have a test system with that cpu at the moment (g4 would use fdcan if asked for perpih_can)
especially unfit sjw values might work for some time unless clocks drift or other
Issues/PRs references