Skip to content

Conversation

AnnsAnns
Copy link
Member

Contribution description

This (re-adds) the original image zoom that used to also be on https://riotguide.annsann.eu

While moving the documentation to the RIOT repository this was (accidentally) not included. The work of the plugins author is even used by Starlight itself in their own documentation https://github.com/withastro/starlight/blob/main/docs/astro.config.mjs#L4

This also fixes a minor prints mistake in the makefile that we didnt catch before in #21730

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: doc Area: Documentation label Sep 24, 2025
@AnnsAnns
Copy link
Member Author

Lets wait for #21741 before this (package-lock will most likely be different)

@AnnsAnns AnnsAnns marked this pull request as draft September 24, 2025 11:00
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Sep 24, 2025
@riot-ci
Copy link

riot-ci commented Sep 24, 2025

Murdock results

✔️ PASSED

9f596f6 doc/starlight: fix incorrect makefile prints

Success Failures Total Runtime
1 0 1 01m:50s

Artifacts

@Teufelchen1
Copy link
Contributor

Lets wait for #21741 before this (package-lock will most likely be different)

That got merged. Please rebase.

@AnnsAnns
Copy link
Member Author

AnnsAnns commented Oct 6, 2025

Rebased & Squashed

@AnnsAnns AnnsAnns marked this pull request as ready for review October 6, 2025 10:02
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate "reviewing" lock files...
LGTM

@Teufelchen1 Teufelchen1 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 6, 2025
@Teufelchen1 Teufelchen1 enabled auto-merge October 6, 2025 10:32
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Oct 6, 2025
Merged via the queue into RIOT-OS:master with commit 694114c Oct 6, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants