-
Notifications
You must be signed in to change notification settings - Fork 2.1k
doc/starlight: Update dependencies, add image zoom, fix wrong prints #21742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets wait for #21741 before this (package-lock will most likely be different) |
That got merged. Please rebase. |
12d3ca2
to
25018bf
Compare
25018bf
to
9f596f6
Compare
Rebased & Squashed |
Teufelchen1
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate "reviewing" lock files...
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: doc
Area: Documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This (re-adds) the original image zoom that used to also be on https://riotguide.annsann.eu
While moving the documentation to the RIOT repository this was (accidentally) not included. The work of the plugins author is even used by Starlight itself in their own documentation https://github.com/withastro/starlight/blob/main/docs/astro.config.mjs#L4
This also fixes a minor prints mistake in the makefile that we didnt catch before in #21730
Testing procedure
Issues/PRs references