Skip to content

Conversation

baptleduc
Copy link
Contributor

Contribution description

This PR renames the existing ads101x driver to ads1x1x.
The purpose of this change is to prepare the codebase and to simplify the review process for supporting both the ADS101x and ADS111x families in a unified driver.

No functional changes are introduced in this PR.
Only file names, Kconfig symbols, defines macros, and related references have been updated to reflect the new driver name.

This rename will simplify the review process for upcoming PR that extend the driver to handle the ADS111x family.

Testing procedure

Build and run existing tests/drivers/ads1x1x (now renamed accordingly) to confirm no regressions.

Issues/PRs references

A follow-up PR will introduce ADS111x support and internal handling of family-specific differences.

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Sep 20, 2025
@baptleduc baptleduc force-pushed the rename-ads101x-driver branch from 464f63b to 43e3aad Compare September 20, 2025 10:21
@crasbe crasbe added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 21, 2025
@riot-ci
Copy link

riot-ci commented Sep 21, 2025

Murdock results

✔️ PASSED

3fcc23a drivers/ads101x: rename doxygen excludes

Success Failures Total Runtime
10516 0 10516 14m:04s

Artifacts

@baptleduc
Copy link
Contributor Author

The macro defines weren’t documented before I renamed them, which caused the CI to fail after the renaming.
What I don’t understand is how the CI passed before, since it shouldn’t have.

@leandrolanzieri
Copy link
Contributor

The failure seems to be related to moving the Kconfig file:

kconfiglib.KconfigError: /tmp/dwq.0.1912543697952842/44aa831c8a8590889923f0e364609cb7/drivers/Kconfig:32: '/tmp/dwq.0.1912543697952842/44aa831c8a8590889923f0e364609cb7/drivers/ads101x/Kconfig' not found (in 'rsource "ads101x/Kconfig"'). Check that environment variables are set correctly (e.g. $srctree, which is unset or blank). Also note that unset environment variables expand to the empty string.

You probably need to also update this line:

rsource "ads101x/Kconfig"

@baptleduc
Copy link
Contributor Author

Ok it passed Murdock CI. But the static tests always failed because I didn't touch the documentation during the renaming process, and it was missing from the start.

@leandrolanzieri leandrolanzieri added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Sep 25, 2025
@baptleduc
Copy link
Contributor Author

So do I need to comment the macros for the review ?

@maribu
Copy link
Member

maribu commented Sep 30, 2025

The alternative to adding Doxygen comments documenting the macros would be to update the list of expected Doxygen errors. That list will contain exceptions for the old file, but is missing them for the new file.

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants