-
Notifications
You must be signed in to change notification settings - Fork 2.1k
drivers: rename ads101x driver to ads1x1x #21731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
464f63b
to
43e3aad
Compare
The macro defines weren’t documented before I renamed them, which caused the CI to fail after the renaming. |
The failure seems to be related to moving the Kconfig file:
You probably need to also update this line: Line 32 in db7a67b
|
Ok it passed Murdock CI. But the static tests always failed because I didn't touch the documentation during the renaming process, and it was missing from the start. |
So do I need to comment the macros for the review ? |
The alternative to adding Doxygen comments documenting the macros would be to update the list of expected Doxygen errors. That list will contain exceptions for the old file, but is missing them for the new file. |
Contribution description
This PR renames the existing
ads101x
driver toads1x1x
.The purpose of this change is to prepare the codebase and to simplify the review process for supporting both the ADS101x and ADS111x families in a unified driver.
No functional changes are introduced in this PR.
Only file names, Kconfig symbols, defines macros, and related references have been updated to reflect the new driver name.
This rename will simplify the review process for upcoming PR that extend the driver to handle the ADS111x family.
Testing procedure
Build and run existing
tests/drivers/ads1x1x
(now renamed accordingly) to confirm no regressions.Issues/PRs references
A follow-up PR will introduce
ADS111x
support and internal handling of family-specific differences.