chore: the address of keychain internal also tweak #273
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
=======================================
- Coverage 2.8% 2.8% -0.0%
=======================================
Files 15 15
Lines 1914 1921 +7
=======================================
Hits 53 53
- Misses 1861 1868 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I don't see issues with this proposal, as there may be cases in which it's necessary to add the tapret tweak on an output whose address doesn't belong to the tapret keychain. I'd even argue we could skip the check on the keychain altogether, giving more freedom to wallet developers to manage keychains as they see fit. Those not needing the additional freedom can always avoid receiving on tweaked addresses belonging to unexpected keychains. |
|
Yes, let's skip the check altogether then. Also, in v0.12 there is no such thing anyway |
|
Why did you close the PR? It was fine, you've could just add a commit removing the check on top... |
Crayon-Shin-chan-bitlightlabs
force-pushed
the
master
branch
from
b876098 to
3b3d83e
Compare
Crayon-Shin-chan-bitlightlabs
force-pushed
the
master
branch
from
3b3d83e to
ba99f12
Compare
Sorry, I do not get why/where you need to use |
| let keychain = keychain.into_inner(); | ||
| if keychain == RgbKeychain::Internal as u8 || keychain == RgbKeychain::Tapret as u8 { |
There was a problem hiding this comment.
I meant let's just remove these to lines (the check) altogether
We integrated the taproot advanced script with RGB, such as HTLC script. When we perform refund or redeem operations, we need to transfer the corresponding BTC to the keychain internal that bp wallet will known these utxos