Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vendor machines and Jukebox work with electricity #1447

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

David-Goru
Copy link
Contributor

Summary

This PR aims to add electricity consumption to the vendor machines and the jukebox

The four vendor machines (HotDrinks, RobustSoftdrinks, SecTech, YouTool) and the jukebox now consume electricity, both while idle and while in use

Electricity consumption amounts per tick (when connected to the grid) are placeholders. For reference, in this PR they're originally set to:
Jukebox: 0.5 while off/idle, 5 while on/playing music
Vendors: 0.5 while idle, 10 once when using the machine (only during one tick)

Disclaimer:
This was done quite some time ago, as I was waiting for a previous pull request to be merged before creating a new one. Didn't want to delete these changes, but can't dedicate as much time to this PR as I did with the previous PR, so no images/videos. As a side note, I was "davidgomez" on Discord, but had to leave from the Discord channel as that account has become a work-only account. If anyone needs to contact me through discord, I've joined the server with my secondary account called "Nano" ("nanogoru")

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Testing

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Related issues/PRs

Closes #1438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make vendor machines and Jukebox work with electricity
2 participants