Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Atoms into Images! #375

Merged
merged 30 commits into from
Jul 27, 2024
Merged

Turn Atoms into Images! #375

merged 30 commits into from
Jul 27, 2024

Conversation

RyanR712
Copy link
Collaborator

No description provided.

@RyanR712 RyanR712 added the Enhancement New feature label Mar 18, 2024
@RyanR712 RyanR712 added this to the PMH 2.0.0 milestone Mar 18, 2024
@RyanR712 RyanR712 self-assigned this Mar 18, 2024
@RyanR712 RyanR712 linked an issue Mar 18, 2024 that may be closed by this pull request
Replace atoms with text images #332
Closed
RyanR712 and others added 19 commits March 19, 2024 19:12
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
c761e31
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
905c93d
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
a9e9806
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
b6fec49
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
e1f89ae
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
b4c5354
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
3a8842e
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
b59e3c9
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
dd0c1c9
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
8c370c7
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
b1d3ba7
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
935d787
@RyanR712
Rudimentary image placement
e1d6ad0
@RyanR712
Docs cleanup, bounding boxes, offsets
285d88a
@RyanR712
Properly scaled images, starts of color changes
fbbcc61
@RyanR712
Better bounding box bonanza
1790969
@RyanR712
Proper collision detection restored
dafa21a
@RyanR712
Modified tests to fit new Rectangle calculation
cf48dac
@RyanR712
Merge branch 'master' into 332-atom-text-to-images
08f59a3
@RyanR712 RyanR712 added the API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning label May 10, 2024
@RyanR712
Copy link
Collaborator Author

Marking as ready for review. All letters load and change color according to theme

@RyanR712 RyanR712 marked this pull request as ready for review July 25, 2024 14:09
James-Oswald
James-Oswald reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@James-Oswald James-Oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

src/DrawTools/AtomTool.ts Outdated Show resolved Hide resolved
src/AEG/AtomNode.ts Show resolved Hide resolved
src/SharedToolUtils/DrawUtils.ts Outdated Show resolved Hide resolved
James-Oswald
James-Oswald approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@James-Oswald James-Oswald left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge once you have reviewed my change. You are free to release this as 1.3.0

@RyanR712 RyanR712 merged commit 859fde0 into master Jul 27, 2024
6 checks passed
@RyanR712 RyanR712 deleted the 332-atom-text-to-images branch July 27, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Oswald James-Oswald James-Oswald approved these changes

Assignees

@RyanR712 RyanR712

Labels
API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning Enhancement New feature
Projects
None yet
Milestone
PMH 2.0.0
Development

Successfully merging this pull request may close these issues.

Replace atoms with text images
2 participants
@RyanR712 @James-Oswald