code refactored with some func variable name update #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
R1j1t
added
documentation
yechielb2000
reviewed
Apr 2, 2023
| import spacy | ||
| from .contextualSpellCheck import ContextualSpellCheck |
There was a problem hiding this comment.
This is no longer works. please write the full path of the import
|
|
||
| __all__ = ["ContextualSpellCheck", "add_to_pipe"] | ||
|
|
||
|
|
||
| def add_to_pipe(nlp, **kwargs): | ||
| def add_to_pipe(nlp: spacy.language.Language, **kwargs): |
There was a problem hiding this comment.
Annotations for return type are missing.
|
|
||
| try: | ||
| # First open() for user specified word addition to vocab | ||
| with open(vocab_path, encoding="utf8") as vocab_file_buffer: |
There was a problem hiding this comment.
You are using utf8 too many time. maybe its better to make it as const param like this.
FORMAT_UTF8 = 'utf8'
| @@ -439,14 +430,31 @@ def time_log(fn_name, relative_time): | |||
| print(fn_name, "took: ", time_now - relative_time) | |||
| return datetime.now() | |||
|
|
|||
| @deprecate("has_spelling_correction") | |||
| def token_require_spell_check(self, token) -> bool: | |||
There was a problem hiding this comment.
Function is getting token without annotations.
| from functools import wraps | ||
|
|
||
|
|
||
| def deprecate(new_function_name: str = ""): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve code readability, improve func/var naming conventions inline with Improve general code quality for maintenance purposes #25
Checklist