v2: move module scoped vars to segments when appropriate#8388
Draft
v2: move module scoped vars to segments when appropriate#8388
Conversation
|
wmertens
force-pushed
the
v2-move-module-scope
branch
from
c6aab68 to
9200b9c
Compare
|
@wmertens ℹ️ Promptless reviewed this request and did not find a docs change to propose. |
wmertens
force-pushed
the
v2-move-module-scope
branch
2 times, most recently
from
9c959b5 to
27d233d
Compare
wmertens
force-pushed
the
v2-move-module-scope
branch
from
27d233d to
339702f
Compare
maiieul
reviewed
Feb 25, 2026
Member
Author
|
@maiieul it's a perf change, moving the qrl creation as far up the scope as possible. That way, we create less objects and everything is faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.