Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes "url" argument must be of type string with nodejs 20 #378

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: fixes "url" argument must be of type string with nodejs 20 #378

wants to merge 4 commits into from

Conversation

lygstate
Copy link

@lygstate lygstate commented Aug 24, 2024 •
edited
Loading

Acceptance Checklist

  • Story: Code is focused on the linked stories and solves a problem
  • One of:
    • For Bugs: A unit test is added or an existing one modified
    • For Features: New unit tests are added covering the new functions or modifications
  • Code Documentation changes are included for public interfaces and important / complex additions
  • External Documentation is included for API changes, or other external facing interfaces

Review Checklist

  • The code does not duplicate existing functionality that exists elsewhere
  • The code has been linted and follows team practices and style guidelines
  • The changes in the PR are relevant to the title
    • changes not related should be moved to a different PR
  • All errors or error handling is actionable, and informs the viewer on how to correct it

Fixes #377

@lygstate lygstate requested a review from a team as a code owner August 24, 2024 04:36
@lygstate
fix: fixes "url" argument must be of type string with nodejs 20
42d4a2d 
node:internal/errors:541
      throw error;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string. Received undefined
    at Url.parse (node:url:170:3)
    at Object.urlParse [as parse] (node:url:141:13)
    at new FtpServer (C:\work\xemu\xemu-bsp-list\ftp-srv\src\index.js:34:24)
    at startFtpServer (C:\work\xemu\xemu-bsp-list\ftp-srv\bin\index.js:133:21)
    at Object.<anonymous> (C:\work\xemu\xemu-bsp-list\ftp-srv\bin\index.js:11:1)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v20.12.0
@lygstate lygstate force-pushed the main branch 3 times, most recently from 9a09651 to 89846a1 Compare August 24, 2024 04:56
@lygstate lygstate changed the title Remove the need of log in src/index.js fix: fixes "url" argument must be of type string with nodejs 20 Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buyan is not compat with webpack, can we make use of buyan only in testcase?
1 participant
@lygstate