fix: Fixed passive mode address when connecting from localhost

[dmkng]

No description provided.

[trs]

I'd rather see this expanded into if blocks instead of ternary operators.
And a function to test if a given IP is "local" would make it clear.

function isLocalIP(ip) {
  return ip === '127.0.0.1' || ip === 'localhost' || ip == '::1'
}

...

let address = this.server.options.pasv_url;
if (isLocalIP(this.ip)) {
  address = this.ip;
}

[dmkng]

I think that IP can never be localhost because it's hostname. So it can be done like that:

function isLocalIP(ip) {
  return ip === '127.0.0.1' || ip == '::1';
}

...

let address = (isLocalIP(this.ip) ? this.ip : this.server.options.pasv_url);
// or
let address = this.server.options.pasv_url;
if (isLocalIP(this.ip)) {
  address = this.ip;
}

or maybe make pasv_url option as callback called every time when someone sends PASV command to the server? Connected user's IP will be passed to the callback parameters and server developer will handle connecting from localhost by itself.

[trs]

If there becomes a need to make it a callback it can be. The only reason I see to make it a callback would be for this exact case.

That looks good to me. I'd rather the if block only because it's clearer to me at a glance.

[trs]

That method can go in https://github.com/trs/ftp-srv/tree/master/src/helpers

[trs]

Added to: #168