Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate: grab headers and build values in one stream #7

Merged
merged 1 commit into from
Aug 10, 2020
Merged

generate: grab headers and build values in one stream #7

merged 1 commit into from
Aug 10, 2020

Conversation

trs
Copy link
Contributor

@trs trs commented Aug 8, 2020 •
edited
Loading

With the help of uhop/stream-json#78 (comment), we can use a single stream to get the keys and build the objects.

@trs trs added the refactor label Aug 8, 2020
@trs trs self-assigned this Aug 8, 2020
@trs trs marked this pull request as ready for review August 10, 2020 15:40
@trs trs requested a review from a team August 10, 2020 15:41
matt-forster
matt-forster approved these changes Aug 10, 2020
View reviewed changes
Copy link

@matt-forster matt-forster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@trs trs merged commit c62ac76 into master Aug 10, 2020
@trs trs deleted the single-stream-generate branch August 10, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-forster matt-forster matt-forster approved these changes

Assignees

@trs trs

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trs @matt-forster