fix: build data from gc json api instead of csv #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trs
force-pushed
the
fix-data-encoding
branch
4 times, most recently
from
59c6a8a to
6412a83
Compare
The csv that is downloaded is in a weird text format (likely Windows 1252), this causes special characters (like accents) to be invalid in utf8. Instead, we can use the api for this purpose to get a valid utf8 response instead.
|
Sorry! This slipped through the cracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csv that is downloaded is in a weird text format (likely Windows 1252), this causes special characters (like accents) to be invalid in utf8.
Instead, we can use the api from stats can for this purpose to get a valid utf8 response instead.